Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2673427ybv; Mon, 24 Feb 2020 09:24:44 -0800 (PST) X-Google-Smtp-Source: APXvYqxobGsMkhcdjPLXZ084NLX23859RsW+8xZrJgzzio+SxcO0wg68b0i1HD+C0fQLmFf2RTbY X-Received: by 2002:a05:6830:1257:: with SMTP id s23mr41072668otp.241.1582565084338; Mon, 24 Feb 2020 09:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582565084; cv=none; d=google.com; s=arc-20160816; b=MMJG9DiD8CxObithMGLN8Bg+/QKNMa38J8w1Qxttff/oqba0WCD03oUNHuEWV7Fxyr v84C2cmn1V84T6ZtaSul0frj/i8ML2DZyXXaKQz5A5if45jEQFOPAllzA0pf0E6pBa3Y V5/mV3fMpWyrhRk0+kkVi0aedZTU6lmh84zYlVaM4wDoSOUQ+RR8PTN8tUJ3kMVa7jxr 7X4oVW6FvfLMit9vOjXt93lErUewCL0Fa+1rEjEIQqjG65DUUE60Iz0J7SqN9cn7L6mG LRD7/UKy60y2vGCTcoQXfhC6jpQqUJrhxVcgBFr0cQKatTTNX2lu5oAQmQNNqe8zdW6v NI3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=ZazMyVGt0wjoqsGmPEwuhfYUdgJfrJc8EOd1yNfzgdU=; b=tCVNuECDFOXKGMcu16RZwCH2oNxM6+czPAsN/xrMK9fQ8pdrigkL0nGTQR/udJqXpA AJ7HprJUOnEI+vSiBy6YQHV/yAzr8SlCnNXOyuJtEHazzzkkSzoqPAlkYqSGrP4jow6u Mu1OT6Ytl882jXkqZv0IZzQ3zSGV7S5PlJQJG6pvGJWbZ50Vz8YjMV1d3qvvRxD+8sQk ON0ZDHRqZa6RCiw6DgXoY2yc57HqxynKySQEKgoeS2dlp7IOJ4xD2ofdVjI+2UqXgtXL nvSwrlSjzrD9pc130SlgtLWiuLDzXJM6ExhhOXX6QpUY1KBSGM89rJVk3CtE5Ob9cBZ7 cXjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si6473559otq.137.2020.02.24.09.24.31; Mon, 24 Feb 2020 09:24:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728071AbgBXRX4 (ORCPT + 99 others); Mon, 24 Feb 2020 12:23:56 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41113 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727664AbgBXRX4 (ORCPT ); Mon, 24 Feb 2020 12:23:56 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1j6HSR-0003Aa-Cw; Mon, 24 Feb 2020 18:23:51 +0100 Message-ID: <5d0f20b76e31360372a410983b013551062e9a91.camel@pengutronix.de> Subject: Re: [PATCH v3 4/4] arm64: dts: imx8mq: add DCSS node From: Lucas Stach To: Laurentiu Palcu , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: agx@sigxcpu.org, lukas@mntmn.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 24 Feb 2020 18:23:51 +0100 In-Reply-To: <1575625964-27102-5-git-send-email-laurentiu.palcu@nxp.com> References: <1575625964-27102-1-git-send-email-laurentiu.palcu@nxp.com> <1575625964-27102-5-git-send-email-laurentiu.palcu@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > This patch adds the node for iMX8MQ Display Controller Subsystem. > > Signed-off-by: Laurentiu Palcu > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index f6e840c..da7e485 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -981,6 +981,31 @@ > interrupt-controller; > #interrupt-cells = <1>; > }; > + > + dcss: display-controller@32e00000 { Node address is lower than the irqsteer node, so the dcss node should be added before, not after the irqsteer node in the DT. > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "nxp,imx8mq-dcss"; > + reg = <0x32e00000 0x2d000>, <0x32e2f000 0x1000>; > + interrupts = <6>, <8>, <9>; > + interrupt-names = "ctx_ld", "ctxld_kick", "vblank"; > + interrupt-parent = <&irqsteer>; > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>, > + <&clk IMX8MQ_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MQ_CLK_DISP_RTRM_ROOT>, > + <&clk IMX8MQ_VIDEO2_PLL_OUT>, > + <&clk IMX8MQ_CLK_DISP_DTRC>; > + clock-names = "apb", "axi", "rtrm", "pix", "dtrc"; > + assigned-clocks = <&clk IMX8MQ_CLK_DISP_AXI>, > + <&clk IMX8MQ_CLK_DISP_RTRM>, > + <&clk IMX8MQ_VIDEO2_PLL1_REF_SEL>; > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_800M>, > + <&clk IMX8MQ_SYS1_PLL_800M>, > + <&clk IMX8MQ_CLK_27M>; > + assigned-clock-rates = <800000000>, > + <400000000>; Second line is not aligned to the first one. > + status = "disabled"; > + }; > }; > > gpu: gpu@38000000 {