Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2676741ybv; Mon, 24 Feb 2020 09:28:28 -0800 (PST) X-Google-Smtp-Source: APXvYqywJlvLJILTQtDZOwTn3mlOQ7AThuT1a992Tb4uaiEBZWMJfgAdpSbW8kyZ4yTvlQYmSgVI X-Received: by 2002:aca:f0b:: with SMTP id 11mr154724oip.34.1582565308311; Mon, 24 Feb 2020 09:28:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582565308; cv=none; d=google.com; s=arc-20160816; b=dSYqmj2h+exox3AqjuoOUPWZz90YY1iqGNSp1uuUvVb9mydTfg5umr6VhU9Syp1DUc WgRDA1S3/pKHu5PVsNahXreXGDjkjtZXXYF7yb6zBVkhvIkAEf0qIudXhI7T8KPuSGYo BwNVzMygogfMkS8rn58xD995JSZFoIWDkT8iutBEtk9qfba7AX/gXgsxdcYS4rFK9+4M CnP6Yiy7kV3xxkn1zGFxOhlQv4dNOwl0z2ByLj68uiiWjaPz/zzqJ55gg6XtVDgv9Ew3 vUT6qWBNdgtJ4Px2paXg/mCfl2ILD/UjABp84focsmieGLFWHgsEWmILWpA5ckClYIJw cY9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=XTCb6y6CAghjOEiFmt3Qo0/Af3rvMfGS4cjP1poHF1M=; b=zSaZK1wccfAaOdIvj+x8mLxSbtXo+n9CqYftikwAyH1yF3TwmR8XhIn8mOTxMwuK57 2/Br5OPa9IEiE+QaiW6AiEJztqPGJiWlFn7qg/MsR6EqcqVm3WlnPdKCSK+VeTUhgOXi h/aszjfMo9qq7rluSAJTZijAqKRzsnUP6ljXNKz2RJ+p4f8TOUtzsJkYG6lf8U7JL/gm 1/yp0VrjvzI68DTNzYUAazLuOAwRRBWHxilNMAqA4hIvPRVjKfuGP6VJh6frKfN+8QK0 4MCi7k3UpHuMsGPT8fPBB9hWk6onsrtLUOqFzaVWUcXBauzj+npeEXngq0IbiYnunt3c PUaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i9si6402125otp.139.2020.02.24.09.28.15; Mon, 24 Feb 2020 09:28:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727775AbgBXR1d (ORCPT + 99 others); Mon, 24 Feb 2020 12:27:33 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41593 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbgBXR1d (ORCPT ); Mon, 24 Feb 2020 12:27:33 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1j6HVu-0003xW-G0; Mon, 24 Feb 2020 18:27:26 +0100 Message-ID: <1515559adebe3a6206e9b8e84692b7818709890b.camel@pengutronix.de> Subject: Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ From: Lucas Stach To: Laurentiu Palcu , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: agx@sigxcpu.org, lukas@mntmn.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Date: Mon, 24 Feb 2020 18:27:25 +0100 In-Reply-To: <1575625964-27102-3-git-send-email-laurentiu.palcu@nxp.com> References: <1575625964-27102-1-git-send-email-laurentiu.palcu@nxp.com> <1575625964-27102-3-git-send-email-laurentiu.palcu@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurentiu, just a first drive-by comment, more in-depth review tomorrow. On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > Some of its capabilities include: > * 4K@60fps; > * HDR10; > * one graphics and 2 video pipelines; > * on-the-fly decompression of compressed video and graphics; > > The reference manual can be found here: > https://www.nxp.com/webapp/Download?colCode=IMX8MDQLQRM > > The current patch adds only basic functionality: one primary plane for > graphics, linear, tiled and super-tiled buffers support (no graphics > decompression yet), no HDR10 and no video planes. > > Video planes support and HDR10 will be added in subsequent patches once > per-plane de-gamma/CSC/gamma support is in. > > Signed-off-by: Laurentiu Palcu > --- [...] > diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig > new file mode 100644 > index 00000000..a189dac > --- /dev/null > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > @@ -0,0 +1,8 @@ > +config DRM_IMX_DCSS > + tristate "i.MX8MQ DCSS" > + select RESET_CONTROLLER > + select IMX_IRQSTEER This driver has no build time dependency on the IRQSTEER driver. It needs it at runtime, but those dependencies are normally not described in Kconfig. On the other hand this is missing a "select DRM_KMS_CMA_HELPER". Regards, Lucas