Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arvind Sankar <nivedita@alum.mit.edu>
Date:   Mon, 24 Feb 2020 12:28:57 -0500
To:     Borislav Petkov <bp@suse.de>
Cc:     Arvind Sankar <nivedita@alum.mit.edu>,
        linux-tip-commits@vger.kernel.org,
        Nathan Chancellor <natechancellor@gmail.com>,
        x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [tip: x86/boot] x86/boot/compressed: Remove .eh_frame section
 from bzImage
Message-ID: <20200224172857.GA334627@rani.riverdale.lan>
References: <20200109150218.16544-2-nivedita@alum.mit.edu>
 <158254422067.28353.10866888120950973607.tip-bot2@tip-bot2>
 <20200224164129.GA312716@rani.riverdale.lan>
 <20200224171618.GA29636@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200224171618.GA29636@zn.tnic>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 24, 2020 at 06:16:18PM +0100, Borislav Petkov wrote:
> On Mon, Feb 24, 2020 at 11:41:29AM -0500, Arvind Sankar wrote:
> > Hi Boris, apologies for the confusion and unnecessary work I've created,
> > but I think the preference is to merge the 2-patch series I posted
> > yesterday [1] instead of this.
> > 
> > [1] https://lore.kernel.org/lkml/20200223193715.83729-1-nivedita@alum.mit.edu/
> 
> What guarantees this would work and we won't hit some corner case or
> toolchain configuration this hasn't been tested on?
> 
> If that happens, I need to have a state to revert back to, i.e., this
> patch, discarding .eh_frame explicitly.
> 
> So I'll pick up [1] too, but give people a couple of days - a chance to
> complain about. :)
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

Ok, note that the 2-patch series assumed that it would replace this one,
so it doesn't contain a revert of discarding .eh_frame explicitly for
the compressed kernel.

The first patch of that series at least should be safe enough, it will
stop generating .eh_frame sections in most cases, and shouldn't make any
edge cases worse than before. The second one might be a regression if we
do have some case that still creates them though.