To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       openib-general@openib.org
Subject: Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start
 send-only joins while multicast thread is stopped
References: <1139689341370-68b63fa9b8e76d91@cisco.com>
	<20060211140209.57af1b16.akpm@osdl.org> <ada8xsh49ll.fsf@cisco.com>
	<20060212075037.GA11550@mellanox.co.il>
From: Roland Dreier <rdreier@cisco.com>
Date: Sun, 12 Feb 2006 08:37:48 -0800
In-Reply-To: <20060212075037.GA11550@mellanox.co.il> (Michael S. Tsirkin's
 message of "Sun, 12 Feb 2006 09:50:37 +0200")
Message-ID: <adazmkw3543.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (Jumbo Shrimp, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 771
Lines: 17

    Michael> Basically, its as Andrew said: the lock around clear_bit
    Michael> is there to ensure that ipoib_mcast_send isnt running
    Michael> already when we stop the thread.  Thats why test_bit has
    Michael> to be inside the lock, too.

Makes sense I guess.  If I'm understanding correctly, the lock isn't
really there to serialize the bit ops, but rather to make sure
ipoib_mcast_send() won't do anything after we clear the bit.

Does that mean that there's no reason to take the lock around the set_bit()?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/