Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2728471ybv; Mon, 24 Feb 2020 10:25:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwQh6G6kn7ttuRjw5ziPyv3GSPXVC5y3Nif/wGBKdeBMa2rVEzXqXa5HRaovKBMTbMmPxv0 X-Received: by 2002:aca:c415:: with SMTP id u21mr305262oif.49.1582568752597; Mon, 24 Feb 2020 10:25:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582568752; cv=none; d=google.com; s=arc-20160816; b=uOtBSUuKdyqbTxZ41Kx1+i44hfOypffgoxG7cKTGGrLzNLdxYL2fXu7QqoVA55ren/ vy+/ln8qQE27M+7bnmy1nmgxbiFLKYBPRVVxn/afVPKaT3+x9PyzkMBpuabcTYWZyVng 4JPw6paouDL3WvejRmDdZTBiUWNA6Nm7+ulsj1Of1wSPQXFkWXDAzGkpCtY8j2T0evdz gMVmnSRBAXwjAZ5n/SgA52GtfDbWvPisq9iYuMnvd3ZY7krRX9992dy/KZEAKPFYXSwI Soe6Nljx1OG6B3/+a0H4Se/YSrw5/ybS0+7zlMXOKW0nlxzHHIgAXgqv0vjIt6WBYjzO d+cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=d5hNut4A0wAETG4/f1oFDksThJ1RQ3MTc6OZiACw95o=; b=L/Zy77JLXg877DQOhSex+ARIBBz/uRRZ7OGm9klC3SJO6vNY13rG7UTQbK3HHvVdZA 2140dNsJcN9oMMQskrKGPH+rnZCecg6lpmn+eLIoUKR6lPdZXjf8TRz9lVS3mf9EZGv5 Ncnz5VVTyOHIKjjLJDdsfKfUdM/Dro5E8RxLUKwqDypx/OLIDNCoUcqRp7JcQTp93k7+ oKqwKfdHAHeLwSnNJ15/GPXX63jQBDpzCe+tv4U7iSrMjBlfmHiUsJFTyaSOZF0uV2ms CmaZ/keIk925D45f3I1SmkW6Hj7/KPM03O3mBrJgInntSmpP56Dyk6GYgW/o3EsAo8NX 4SBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v22si5606453oia.30.2020.02.24.10.25.39; Mon, 24 Feb 2020 10:25:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbgBXSZe (ORCPT + 99 others); Mon, 24 Feb 2020 13:25:34 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:36899 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbgBXSZe (ORCPT ); Mon, 24 Feb 2020 13:25:34 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j6IQ0-0002cD-Bx; Mon, 24 Feb 2020 19:25:24 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j6IPy-00016N-Ke; Mon, 24 Feb 2020 19:25:22 +0100 Date: Mon, 24 Feb 2020 19:25:22 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Guenter Roeck Cc: Anson Huang , "wim@linux-watchdog.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH] watchdog: imx2_wdt: Drop .remove callback Message-ID: <20200224182522.33qeusb4xbxxt3o3@pengutronix.de> References: <1582512687-13312-1-git-send-email-Anson.Huang@nxp.com> <20200224102211.clzqw4vtzc4nz5df@pengutronix.de> <33c3778f-fc7e-8564-f767-91aafae03122@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33c3778f-fc7e-8564-f767-91aafae03122@roeck-us.net> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 06:15:17AM -0800, Guenter Roeck wrote: > How would you expect the watchdog core to stop the watchdog > with no stop function in the driver ? I'm not 100% sure, but I think the situation is that you cannot stop the watchdog in the watchdog register range, but if you stop the clock it will never expire. That's why I asked if the devm action callback stops the watchdog. Didn't look into the details though ... Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |