Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2876924ybv; Mon, 24 Feb 2020 13:29:08 -0800 (PST) X-Google-Smtp-Source: APXvYqw+Kt+tqauBGInl3WQrkly4KQNkSUnFdL27BRiv00ZI/RhAYYUXWA9+WnP6tNhXRB3s8T6f X-Received: by 2002:a05:6830:11:: with SMTP id c17mr41557372otp.360.1582579748427; Mon, 24 Feb 2020 13:29:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582579748; cv=none; d=google.com; s=arc-20160816; b=h8rBVu86Jm+qeZr1IIWr1zKwOhs7XhhcNVJdml619Xpl2YAHAGQhIptW69HOlkrQBt K3PYOqQDw3qg1EngCFD7w2FzxSFtRVAJDOUxLQQ4pR8cJPnbWcWSVQQXn0+vSiYHlFT6 1q3dBTvVxvVhdC8KQGaN6AZRoLRznvuR8AYf8ARzRrI2e+tOfSFd2qMDm6J3RJ4r3rZr jzpQ+nROzfLjqh+qId3z3ijGJx54clstidzpQZAIHUhSf+P1idWfKbI4ueITyapnpAif K//dklWCm5SAuE6hQQfmmWaaEeNRhhhXPN8CZGkUBNiAU1lu7dlcHOPPY9oec60/A1iK Y/kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=BN12bO0hkhzOOLrE+LzCJGQKuXXaCeYz6LjDEluV8RI=; b=RXp53itjgs84C5vUvAT3Z+aaTRidqsi+AiBZXjB3Lad14i6PSqspOsiwerXj/cfu6v S/rQO9DJSD6x4A6MG3ZemNfEKEAEYuvEeLxPK7526VpFmNsNlZUFqMAySml0Ro4dFdXB GBNEqLTVMLYq50509XTScKqjCbHQJRLa+euZoEBn+8k9sNUXV2gZjACpzrY6z72jVK17 /oGFjBHRc3GHI7deDobjjczboqfn2j6pVaq2IDc0ju3pOe2K84p2FBhatANLiBs4Dtnx Ltt0DaxiCPKtfZZ8hMACuWi2/8+DZjV3sM4F76zEmPP/NJZiSH0xWdNCVhGB6RgLicDK zRoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si7165897otk.73.2020.02.24.13.28.56; Mon, 24 Feb 2020 13:29:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727935AbgBXV2o (ORCPT + 99 others); Mon, 24 Feb 2020 16:28:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38600 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbgBXV2n (ORCPT ); Mon, 24 Feb 2020 16:28:43 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CB1E8121A82E7; Mon, 24 Feb 2020 13:28:42 -0800 (PST) Date: Mon, 24 Feb 2020 13:28:42 -0800 (PST) Message-Id: <20200224.132842.2112142868734722035.davem@davemloft.net> To: jbi.octave@gmail.com Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com, kuba@kernel.org, linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() From: David Miller In-Reply-To: <20200223231711.157699-5-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> <20200223231711.157699-5-jbi.octave@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 24 Feb 2020 13:28:43 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jules Irenge Date: Sun, 23 Feb 2020 23:16:45 +0000 > Sparse reports a warning at sctp_err_finish() > warning: context imbalance in sctp_err_finish() - unexpected unlock > > The root cause is a missing annotation at sctp_err_finish() > Add the missing __releases(&((__sk)->sk_lock.slock)) annotation > > Signed-off-by: Jules Irenge Applied.