Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2883991ybv; Mon, 24 Feb 2020 13:37:48 -0800 (PST) X-Google-Smtp-Source: APXvYqx9agyuqiRHGnegh3vaNVD0ikrpmmbsh7mUxXFTE8mLzjKpoQKBIPnWZ//aCcF06bMc41Sc X-Received: by 2002:a05:6808:7dd:: with SMTP id f29mr921277oij.67.1582580268257; Mon, 24 Feb 2020 13:37:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582580268; cv=none; d=google.com; s=arc-20160816; b=dTT+ftPdcwsaVUNLvepyNw6kVf6edtk7LRsS3k1kyIlhb1DP5DUltwnvc/ylcE4gA9 s53vE3c+V6HT1AU5GjmckInWQ0A50N9rs6MaubmWKwPAGNF7EQDH/0+cSO9CiCcuQaVI DxaqY1fsYNNJF/pQ7R5bIxPaa57/+GUypxgIRalcgrE+cOvN8pSrRl2z0jYNJnQ9MRNV 6O9ou4twOkSGkclbydAk1xd8bejf4MPk1mTmr4k5ygjlVS3VXSjf40HKcDIsEWUsYALE xEU+AIgoUZYpLqw9YO79q9FbHqlZJXb4YCZII3ZrgQtfxgTLIVaJcJzBW8hToAu0LHdw QrUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=nX5VslAb9aYoRq0onwDHGJTJ67RlRcQ5wURtwjQgsok=; b=tNxMUeAqB8giBZ13AuEUPs1oILWXbK05FWzeC9i9SxDDRePR0fGIyDNYlLRBJ/1TMg PizTv2KSko0ZN5K47eskBvhlqoYncRFhx/129jrc97z6WrG4RqvllhULc3OxYZQjnX9L Dhi16MIK6M+tpssdYMPKnIwQ1X78oCejQn1OE6nU2dUHY56RsX2lc8n4pSLRYnk+DBpT +Tj48vV0giypcuY+gMEdkLXvItUCdzXQgICwjHMFv7wiXtsYV5uLCrFDn9PqF4N6seWD EwxJyjoe2awgEo5Mky8ZahGo0AHwhCYIt/9lzRbhExkCn3vappufIFZUYzt1N7FFJ9GR +pHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=X8jrNEtX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si6143096oic.140.2020.02.24.13.37.35; Mon, 24 Feb 2020 13:37:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=X8jrNEtX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728020AbgBXVhP (ORCPT + 99 others); Mon, 24 Feb 2020 16:37:15 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:32794 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727421AbgBXVhP (ORCPT ); Mon, 24 Feb 2020 16:37:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nX5VslAb9aYoRq0onwDHGJTJ67RlRcQ5wURtwjQgsok=; b=X8jrNEtXW298x3gA4/IDu/10Ny 1ViCr7MxaOAVAjf+Zay51p9ufyNNeifHWxRgfL7eg/f6/9IGK8yNGMSs5mcRTo4GJfD5Oha50wx9X RoWUPQWYyRqvieERC9AWCihjU8tiBSlNZrctgEXFVEsQK7++p7wCg2aKVkS1CvjpiIwt9Ve8v+vRf D7/k++eIpijcp7XpCFPS+rlPj4VcVAUYvWzvnFBPmlk7Gt3lfaziHMCRv1B2QDfMJQkNJcugtekWK xrNSMkT+9Wb9QLRQJEabeqGGgvvnwCrUQqnrBXNB6655cSxapzIfAzu7myQkdoaNjUxv8uHXRfmBc zL8XhDxQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6LPe-0005je-RR; Mon, 24 Feb 2020 21:37:14 +0000 Date: Mon, 24 Feb 2020 13:37:14 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 08/24] mm: Remove 'page_offset' from readahead loop Message-ID: <20200224213714.GE13895@infradead.org> References: <20200219210103.32400-1-willy@infradead.org> <20200219210103.32400-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219210103.32400-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2020 at 01:00:47PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Replace the page_offset variable with 'index + i'. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig