Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2897757ybv; Mon, 24 Feb 2020 13:58:05 -0800 (PST) X-Google-Smtp-Source: APXvYqzloJcNQIqbnIO3EqEOPwYc8+X8wVx9R5q9QEKq24s48GwMznSgPM8plfOwGCPPJDMeQGdT X-Received: by 2002:a9d:116:: with SMTP id 22mr18089331otu.149.1582581485099; Mon, 24 Feb 2020 13:58:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582581485; cv=none; d=google.com; s=arc-20160816; b=NRSj1htwJVuuM5YLiO3+k3F0y6aT9LozCuQqz+H4wLjpk+lf2nTcbLBcxLr1T4AuQl ep5eOqXne9ZmCn4weBZXczPJWODKX8MxmXzYSsp/pqKmz/Fkv3h9HFtnqpdNFaJqjw4f QareglQcvtUJiWkHRFKDY7/u3YT9laz9y5DUaLRBl4BzZkV0fjNtFQLR2bSFqEtL4EF1 TdUu60++e0sH3wtFyJc+89PgNEgS76/ZXYwSeS4q70/lxeT8hW+jP6DC39pYiTCYWyWM q5K8++7zUzPWjz6j300KfOb7sTmVFtNB+112P8TDro5L51xnk4aYmeo/qM8vFBn3gL4b k76A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IhFcixf6xB7flTgkTYeOnbWlEpWZuV6CKSy7ZQez0WI=; b=zYg0ClcZ/FsyMzMcEh73PDUnrSpWifDICMcOn0fBh9o2GCSceClT9jotoFQh+0zlT+ W4qmr6XeN0OYIpN9Rx7hpReyBRLxgsDpy/QEHDUoAZSPum4bggh4US5vTagJqHQUxJKM yIzCoR5XUmzBtYU0fumzk1m2lRAEEBsKWB+mUa3LaB8rjiJT7kPeheA94fazqwgE8HQk eqvOvSlyuuCK5AaXZE2qP2w0e5OLkPQ240c0OU4FhT/jZKEJAmS5UNyWduTfzZ5VkW/o 7dh8Cs7Su1afZGySyJxXIyNZ9zc+J1jtyE6O6hEhSzCD0xqu91LRZLHuHgsL7FJDJ6Dm FVug== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Xsl1VicG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x23si5702156oie.50.2020.02.24.13.57.50; Mon, 24 Feb 2020 13:58:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Xsl1VicG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728132AbgBXV5o (ORCPT + 99 others); Mon, 24 Feb 2020 16:57:44 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:41384 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727421AbgBXV5n (ORCPT ); Mon, 24 Feb 2020 16:57:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IhFcixf6xB7flTgkTYeOnbWlEpWZuV6CKSy7ZQez0WI=; b=Xsl1VicGy/cUMy3nKSfLYsp4JQ XuauTs+SlYeSgQlRLvumnWjOr2cplAYv962X+iwgIS1cxx+dgzmOltxe84qM829HlpGa7tIVs0rCR UHY9vePWsKoMCOJwVPvOJVEDVFCToUF9yNOI+tB8g0de/RYeV2SMFMNQdVuKQtuM7NwbEbskf1eLg dUXO0x+mn96sZpwZlnDzQxbegLQ/KMtN7w/7oKgd1oDm9ELzK0l9J7YruyW3Oz774Ix0HS0VLNMdY vEye7QuENdlHLI1W4ae0sgNhwCA9TIm6YccKAq+w4+qAYpIVZfjL3mSg7AgI6bRAZf2eZBA7qbemA dCabWfIw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6LjT-0006S8-Ch; Mon, 24 Feb 2020 21:57:43 +0000 Date: Mon, 24 Feb 2020 13:57:43 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Johannes Thumshirn , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "cluster-devel@redhat.com" , "ocfs2-devel@oss.oracle.com" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v7 14/24] btrfs: Convert from readpages to readahead Message-ID: <20200224215743.GA24044@infradead.org> References: <20200219210103.32400-1-willy@infradead.org> <20200219210103.32400-15-willy@infradead.org> <20200220134849.GV24185@bombadil.infradead.org> <20200220154658.GA19577@infradead.org> <20200220155452.GX24185@bombadil.infradead.org> <20200220155727.GA32232@infradead.org> <20200224214347.GH13895@infradead.org> <20200224215414.GR24185@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224215414.GR24185@bombadil.infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 01:54:14PM -0800, Matthew Wilcox wrote: > > First I think the implicit ARRAY_SIZE in readahead_page_batch is highly > > dangerous, as it will do the wrong thing when passing a pointer or > > function argument. > > somebody already thought of that ;-) > > #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) Ok. Still find it pretty weird to design a primary interface that just works with an array type.