Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2957015ybv; Mon, 24 Feb 2020 15:14:06 -0800 (PST) X-Google-Smtp-Source: APXvYqxIK+mraGli3Pi9/8ikKtnZO1IpSAQZt07+pguFMGRBgDqO5FBhnHDMzRb685PljjlyXKFe X-Received: by 2002:a9d:7999:: with SMTP id h25mr41808558otm.347.1582586046311; Mon, 24 Feb 2020 15:14:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582586046; cv=none; d=google.com; s=arc-20160816; b=E7lcfsrAkWOs/V3GolO7zCsLDPFsMaa0CWRfE5urA0uWZjOVYUJEGVTmbEagsrS/fX q3JQadzOyO3SGbxBd7Djoo4iloPfmK/e9bdi3GxvY46o1nFERoDdOVqd+BdOsHie0kZp iJRBsOwx7SSBT8xElMRarYDrxDnTAWY9mko6VoIfULxz9nXAga4zA8Yhh9xVlzKYhD8Q 0+fWJj+OFuiauq68gwRe+rQmUIJEtbUAUgNh76SopTPqDO0MXm9lnBlOsRx324z0nLci jJ5pYaORcpFZP9d9iPL9+hrW3Xh6AtmNw6w8UHO21FgctdAneVxkGq/IjqDydhY6O75r vlGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:from:references:cc:to; bh=AaFhvWM6QcL3mQdZXaP5fa+w9dR6VdggX7QVJaiOGfg=; b=AIFF0VvotM1DJoFEvkcg0zi6u/Ah4z4PU8ZDWItpMkPKdGiYUV1OP92YWqnaYHz2NB ghDzWDMNHY8GmV9pJj2Ftfw1SjLwu7fmVX+vnsQfd9LB9H1Ulijl3YRjWT2flNEuvfAU BZgBJjzrHbLO1FsTwIK0UBjiJIMIQqRk8OGMPX0i2LKdLqdOmDzkpguUuEi+jXPdqJRx PYG/eSLCGuyVfwkIZfM6hOwWfY6l6Ak9l6Qh/1+tE5ehXver1N9HenEN112dWvlC8o2O v0TNrQ1yHWEPfgP6lwyemsXgEh1XjS5kN9RtYugshVm4OJiQVEMdM8udIghdEgYybw4t kfZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d26si6478716otc.6.2020.02.24.15.13.52; Mon, 24 Feb 2020 15:14:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728069AbgBXXNr (ORCPT + 99 others); Mon, 24 Feb 2020 18:13:47 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:33849 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727081AbgBXXNr (ORCPT ); Mon, 24 Feb 2020 18:13:47 -0500 Received: by mail-lj1-f195.google.com with SMTP id x7so11994992ljc.1; Mon, 24 Feb 2020 15:13:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=AaFhvWM6QcL3mQdZXaP5fa+w9dR6VdggX7QVJaiOGfg=; b=XCdy1mWrdfoXCyODTgRQQvJIRiHyK2VlsoWywlTdA4GS0x6RRZhCxMrZDYPcEkoyjv rh+yrbcRgxO8O00pyopkooXWw5XyNqIQCEx1697ASrYNAllI0jAUi17DuKDfH9oGfz8+ KnhVJ1HofSgxa3AyafWfAcedu572lq5+i6GPggVZzzUsIar63o6WaX0gCWSXyw6mx2v+ 4nT9lUyr6JH0HpZlRrXhRN092Jn1jLKI0nMAbTZBbvoHPT6PChZZWREY10q/y0Ax9Pk1 1I1U7NDaLnI0197omZfTGjWJrriXMC0PQTIcm65Wblp1xtasDyGmB10t7vRx2yo6HwRg PMtw== X-Gm-Message-State: APjAAAXyvvYV0twxzPc57knHD5UBWAffwJUr6PWMG7PAuv36uHJ+2SwJ skrZaryUFxTIOqK/92xj4Yr5yA1q X-Received: by 2002:a2e:884c:: with SMTP id z12mr32168107ljj.55.1582586024319; Mon, 24 Feb 2020 15:13:44 -0800 (PST) Received: from [10.68.32.192] (broadband-188-32-48-208.ip.moscow.rt.ru. [188.32.48.208]) by smtp.gmail.com with ESMTPSA id x21sm5123824lff.0.2020.02.24.15.13.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2020 15:13:43 -0800 (PST) To: Linus Torvalds , Willy Tarreau Cc: Jens Axboe , Linux Kernel Mailing List , linux-block References: <20200224212352.8640-1-w@1wt.eu> <20200224212352.8640-2-w@1wt.eu> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCQPCZwAFCwkIBwIGFQoJCAsC BBYCAwECHgECF4AWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCW3qdrQIZAQAKCRC1IpWwM1Aw HwF5D/sHp+jswevGj304qvG4vNnbZDr1H8VYlsDUt+Eygwdg9eAVSVZ8yr9CAu9xONr4Ilr1 I1vZRCutdGl5sneXr3JBOJRoyH145ExDzQtHDjqJdoRHyI/QTY2l2YPqH/QY1hsLJr/GKuRi oqUJQoHhdvz/NitR4DciKl5HTQPbDYOpVfl46i0CNvDUsWX7GjMwFwLD77E+wfSeOyXpFc2b tlC9sVUKtkug1nAONEnP41BKZwJ/2D6z5bdVeLfykOAmHoqWitCiXgRPUg4Vzc/ysgK+uKQ8 /S1RuUA83KnXp7z2JNJ6FEcivsbTZd7Ix6XZb9CwnuwiKDzNjffv5dmiM+m5RaUmLVVNgVCW wKQYeTVAspfdwJ5j2gICY+UshALCfRVBWlnGH7iZOfmiErnwcDL0hLEDlajvrnzWPM9953i6 fF3+nr7Lol/behhdY8QdLLErckZBzh+tr0RMl5XKNoB/kEQZPUHK25b140NTSeuYGVxAZg3g 4hobxbOGkzOtnA9gZVjEWxteLNuQ6rmxrvrQDTcLTLEjlTQvQ0uVK4ZeDxWxpECaU7T67khA ja2B8VusTTbvxlNYbLpGxYQmMFIUF5WBfc76ipedPYKJ+itCfZGeNWxjOzEld4/v2BTS0o02 0iMx7FeQdG0fSzgoIVUFj6durkgch+N5P1G9oU+H37kCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJhYhBHZUAzYClA3xkg/kA7UilbAzUDAfBQJb CVF8AhsMBQkDwmcAAAoJELUilbAzUDAfB8cQALnqSjpnPtFiWGfxPeq4nkfCN8QEAjb0Rg+a 3fy1LiquAn003DyC92qphcGkCLN75YcaGlp33M/HrjrK1cttr7biJelb5FncRSUZqbbm0Ymj U4AKyfNrYaPz7vHJuijRNUZR2mntwiKotgLV95yL0dPyZxvOPPnbjF0cCtHfdKhXIt7Syzjb M8k2fmSF0FM+89/hP11aRrs6+qMHSd/s3N3j0hR2Uxsski8q6x+LxU1aHS0FFkSl0m8SiazA Gd1zy4pXC2HhCHstF24Nu5iVLPRwlxFS/+o3nB1ZWTwu8I6s2ZF5TAgBfEONV5MIYH3fOb5+ r/HYPye7puSmQ2LCXy7X5IIsnAoxSrcFYq9nGfHNcXhm5x6WjYC0Kz8l4lfwWo8PIpZ8x57v gTH1PI5R4WdRQijLxLCW/AaiuoEYuOLAoW481XtZb0GRRe+Tm9z/fCbkEveyPiDK7oZahBM7 QdWEEV8mqJoOZ3xxqMlJrxKM9SDF+auB4zWGz5jGzCDAx/0qMUrVn2+v8i4oEKW6IUdV7axW Nk9a+EF5JSTbfv0JBYeSHK3WRklSYLdsMRhaCKhSbwo8Xgn/m6a92fKd3NnObvRe76iIEMSw 60iagNE6AFFzuF/GvoIHb2oDUIX4z+/D0TBWH9ADNptmuE+LZnlPUAAEzRgUFtlN5LtJP8ph Subject: Re: [PATCH 01/10] floppy: cleanup: expand macro FDCS Message-ID: <28e72058-021d-6de0-477e-6038a10d96da@linux.com> Date: Tue, 25 Feb 2020 02:13:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2/25/20 12:53 AM, Linus Torvalds wrote: > So I'd like to see that second step that does the > > -static int fdc; /* current fdc */ > +static int current_fdc; > > change. > > We already call the global 'drive' variable 'current_drive', so it > really is 'fdc' that is misnamed and ambiguous because it then has two > different cases: the global 'fdc' and then the various shadowing local > 'fdc' variables (or function arguments). > > Mind adding that too? Slightly less automatic, I agree, because then > you really do have to disambiguate between the "is this the shadowed > use of a local 'fdc'" case or the "this is the global 'fdc' use" case. > > Can coccinelle do that? Willy, if you don't want to spend your time with this code anymore I can prepare patсhes for the second step. I know coccinelle and could try to automate this transformation. At first sight your patches look good to me. I will answer to the top email after more accurate review. Thanks, Denis