Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3064189ybv; Mon, 24 Feb 2020 17:24:24 -0800 (PST) X-Google-Smtp-Source: APXvYqw0i9aClGxJSUHvh1Q7AX6rSLXzkmATPRx1NaAjyu24O0o1LJTUOGxUZVRKiuusOtsUGgk3 X-Received: by 2002:a9d:4c14:: with SMTP id l20mr42035136otf.125.1582593863670; Mon, 24 Feb 2020 17:24:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582593863; cv=none; d=google.com; s=arc-20160816; b=JWuMluScsTaSaFKdQdVgumzF5SM7IEYEEaVQR2bjD8mbeTe/CX7opkWai1zoVgAd9D AoUag2jImfwvtD6LGfIf+gN19c08H/KR0zJXZE7Z6mkDNxLdFUFylLo0XpgmkxrL9BA7 69bnuWy7KcF+PxCxlHarcnNv4MMHPxLAtvQGExtTEGBW1/T1fUoOrAKqyrb+PxL79uJG PUexoYj3C8D3Y6PuvaGr8dF2DUZ7YVMgl83bGmaiDSQInqn8i8tlchzoSUrAvrJ5zTLo d7wzKOd+vOgxmLEokPDLYjsidbuZYKwrrhrHS6CmaMK+clmCyXSJCI7Qgg+e+mzO8UQx tvAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zIbp8wKGXVLLxHhTy31TRd9NVAkz0p3dg03obFlrOdo=; b=NI8zOY6dgs7CUo4VNu+Q1FVNiJaFonVJz8tfiZG/ZKVXvILM49EdYtiGZC6YzbHBMn qlldlraywGlGzFiovhfEwq8oJ8jlt3rS/o2ycsXmA/H+TwL22pQEWiDzo3lrBXqKroMG uZqj3KoK1avztTS+LNDzlCdwYClL0Qrh6aZGvsbunBpdQo1b0R1fG9BCh2iLdILteITF iuvNzJkU8Xjfvy4Avy8TY7481Vlam2d93G+Eu7X9npXVarMuuY0ZTHXeupgpFM19TCff BCAfj1pXb0CtEvxWr+3WfVG9Xmc4JeWf6SfHJqrC8b19EK/p7zdm+KM+WSiSdBw3LdYk TanQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cpUBPuKW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si7493178otf.36.2020.02.24.17.24.10; Mon, 24 Feb 2020 17:24:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cpUBPuKW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728541AbgBYBYA (ORCPT + 99 others); Mon, 24 Feb 2020 20:24:00 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:35835 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728135AbgBYBYA (ORCPT ); Mon, 24 Feb 2020 20:24:00 -0500 Received: by mail-il1-f193.google.com with SMTP id g12so9422830ild.2 for ; Mon, 24 Feb 2020 17:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zIbp8wKGXVLLxHhTy31TRd9NVAkz0p3dg03obFlrOdo=; b=cpUBPuKWaRuBRB9AUcAXjl3OxvWKcMY4ENFehlzSMbeMTdlP0YOoJTcPxN3/4bl9iN y9szjZKNXJ4UqMrX6E0+0aiSkCMadw20DJuQk6IEO3ouJpLd4MgEZuCv4MVqKwNnRNTT b6VQbn8bPxwvWbnqID6P7n5DHk4H+xn+aUMpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zIbp8wKGXVLLxHhTy31TRd9NVAkz0p3dg03obFlrOdo=; b=GxJIz//FqznoTa0zfchdu4zy3ytrAi9k4AzD3FPr2A+rMQDnCy+7aEj7uG/NnV34Ci 65SU68NNqthrz+OmoQNJsmU9cQuzUzk3oXI4N2V17LnKTZQl25IUJAuu22VK0RDiR15o 07oceKylIceClI99VzODroy5l2c/JTBXfc2NQ0QSw7JeFqrXNDJ+7nqaCoZbIjVA2fJg L91ZaMGrUhvVZi5KVmNL5LFlacr1QPcJO9iArcxkYEYNwapxIGzcC3ka5ILHVbkNgdoL 1lIy/mzKnBzm1SBuSxE9UOdGh27hC4bZBlyqKTYy2+ZNC5CIpV02R61l96UigCUdKQbm kYfw== X-Gm-Message-State: APjAAAVcGaMcAt79r4n/0/BWLfNIAyQB9RWkNmurlXnVp3mHoTi/2fQz 5Y0+eAxNtWOwD7Ccx9U1dWeDOZmngi1Om6fP0JPQDA== X-Received: by 2002:a92:cc04:: with SMTP id s4mr40784855ilp.193.1582593837805; Mon, 24 Feb 2020 17:23:57 -0800 (PST) MIME-Version: 1.0 References: <20200214062637.216209-1-evanbenn@chromium.org> <20200214172512.1.I02ebc5b8743b1a71e0e15f68ea77e506d4e6f840@changeid> <20200219223046.GA16537@bogus> <20200219232005.GA9737@roeck-us.net> <1326f594-3cfd-c03d-4f2c-50eeb75724b2@amlogic.com> In-Reply-To: <1326f594-3cfd-c03d-4f2c-50eeb75724b2@amlogic.com> From: Julius Werner Date: Mon, 24 Feb 2020 17:23:46 -0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible To: Xingyu Chen Cc: Julius Werner , Evan Benn , Guenter Roeck , Rob Herring , LKML , devicetree@vger.kernel.org, "David S. Miller" , Jonathan Cameron , Mauro Carvalho Chehab , Wim Van Sebroeck , Greg Kroah-Hartman , Mark Rutland , linux-watchdog@vger.kernel.org, Jianxin Pan , Yonghui Yu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The SMC function ID may be solved by the DTS, but the wdt indexs(Eg: > SMCWD_INFO) are also different > for each vendor. The imx_sc_wdt.c is also use the SMC to operate the > WDT, but the wdt indexs(Eg: IMX_SIP_TIMER_START_WDOG) > are different from ours. IMO, If the ATF can implement a common hal > interface and index for watchdog, then writing a > common smc wdt driver will be easier to compatible with all vendors. The MediaTek driver is still in flux (e.g. still being reviewed in Trusted Firmware here: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405), we can still change it. So if we can now decide on making this a "standard" driver, we can change the MediaTek interface to match IMX and standardize on that. (There are existing Chromebooks shipped with a different interface, but we could handle those separately with downstream patches. I think having a unified interface that will prevent this problem in the future would be worth some extra complication right now.)