Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] KVM: LAPIC: Recalculate apic map in batch
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>
References: <1582022829-27032-1-git-send-email-wanpengli@tencent.com>
 <87zhdg84n6.fsf@vitty.brq.redhat.com>
 <CANRm+Cyx+J+YK8FzFBV8LRNPeCaXPc93vjFdpA0D_hA+wrpywQ@mail.gmail.com>
 <f433ff7e-72de-e2fd-5b71-a9ac92769c03@redhat.com>
 <CANRm+CwfaZHHPyxC1qz_uq6ayw6vg2n0apLPoPH5dKXyy4FLeg@mail.gmail.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <629c37b6-2589-9073-369c-7026ebf13a51@redhat.com>
Date:   Tue, 25 Feb 2020 09:50:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <CANRm+CwfaZHHPyxC1qz_uq6ayw6vg2n0apLPoPH5dKXyy4FLeg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 25/02/20 09:31, Wanpeng Li wrote:
> On Tue, 25 Feb 2020 at 16:07, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 19/02/20 01:47, Wanpeng Li wrote:
>>>> An alternative idea: instead of making every caller return bool and
>>>> every call site handle the result (once) just add a
>>>> KVM_REQ_APIC_MAP_RECALC flag or a boolean flag to struct kvm. I
>>>> understand it may not be that easy as it sounds as we may be conunting
>>>> on valid mapping somewhere before we actually get to handiling
>>> Yes.
>>>
>>>> KVM_REQ_APIC_MAP_RECALC but we may preserve *some*
>>>> recalculate_apic_map() calls (and make it reset KVM_REQ_APIC_MAP_RECALC).
>>> Paolo, keep the caller return bool or add a booleen flag to struct
>>> kvm, what do you think?
>>
>> A third possibility: add an apic_map field to struct kvm_lapic, so that
>> you don't have to add bool return values everywhere.
> 
> This apic_map field is boolean, right?

Right, and the name should really be apic_map_dirty.

Paolo