Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3425098ybv; Tue, 25 Feb 2020 01:04:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwzeMpPMeGz/lZt5LqXFLOOhXgifx2/WJubwFRu9G1tvzxq7eQEH44omAW5k7cUmBK/LRPl X-Received: by 2002:a9d:62d8:: with SMTP id z24mr42366986otk.362.1582621444055; Tue, 25 Feb 2020 01:04:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582621444; cv=none; d=google.com; s=arc-20160816; b=opgS8fYwPVndqUWt/LdfNn24S2P8/FLlLVrZz9BBGOywAkX0KAqTXvGQxAn+7qEOKy WZEjf6lqeQmiyqniHPz3RAPHfNuu9MSROmmHhtxDKU7bGri4vRPatVkdBRE7XCF3cA9D qFEQCSS6Yw6SApH95Rc9aRM5k46ohaOjIrvNGKNs+b6NrRKTGYWc7ZERR7mgHphAAWl7 580WRqhmkh9O9JXtAgF2PIQ80Q26x8aGScCHLmV911zt+p121RiJgGQP/4CSyIyy4oXk sOMi4Ce/QRK5jiy3gmH5k8VSuaehlVKSnBV0GGtIPOIPylp68st4ftU7tBt5gFQgQGCn zKNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VOGRi0H/fgf4jtv3+Of/MaeRWfPq6kzoG588u46zBro=; b=Y4zuNk2fqEkYjKmFanhzw1ulNS/1ZkdVpJcyRGp2I40SwVsFr6wTByZFxi2uivDNRG 22bAn+GFJnOw41o8X+2t2FADNp0SKBQvoBz44MVVhWWHbaPRblS85ZRlkG40lxC/e1uY t6awqvTZ5eZOoH5x4MTJkVZK49qqCscptoC4QeHS3NI7kbkdNTAkRWm1Rmz8C9x3qXcz 59PdwD/rlE4SRSw31H6VWRLAq6wblDjKBAAmDz5RCX6z1+s6g7jVpBBCRhEm7LmaWIyA z44UeE9NhaQInWZ83aLXPcbje7X1OdjidathmihPVJ3AKCRaglVcEqsWnKqARbWRK5cn BOnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c22si7266803otr.97.2020.02.25.01.03.51; Tue, 25 Feb 2020 01:04:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729614AbgBYJC2 (ORCPT + 99 others); Tue, 25 Feb 2020 04:02:28 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:39138 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729153AbgBYJC2 (ORCPT ); Tue, 25 Feb 2020 04:02:28 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 1C7BB921633353B4CAA3; Tue, 25 Feb 2020 17:02:21 +0800 (CST) Received: from linux-TFkxOR.huawei.com (10.175.104.212) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 17:02:10 +0800 From: Heyi Guo To: CC: , Heyi Guo , Marc Zyngier , Thomas Gleixner , Jason Cooper Subject: [PATCH] irq-gic-v3-its: fix access width for gicr_syncr Date: Tue, 25 Feb 2020 17:00:23 +0800 Message-ID: <20200225090023.28020-1-guoheyi@huawei.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.212] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org GICR_SYNCR is a 32bit register, so it is better to access it with 32bit access width, though we have not seen any real problem. Signed-off-by: Heyi Guo --- Cc: Marc Zyngier Cc: Thomas Gleixner Cc: Jason Cooper --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 65a11257d220..5c6790e3bfbf 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -1321,7 +1321,7 @@ static void lpi_write_config(struct irq_data *d, u8 clr, u8 set) static void wait_for_syncr(void __iomem *rdbase) { - while (gic_read_lpir(rdbase + GICR_SYNCR) & 1) + while (readl_relaxed(rdbase + GICR_SYNCR) & 1) cpu_relax(); } -- 2.19.1