Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3480239ybv; Tue, 25 Feb 2020 02:05:25 -0800 (PST) X-Google-Smtp-Source: APXvYqyIZn1Cpic5JJ1qcpWA4sZWBaSZQTbNuuC5zDHgL2/AWVa9nqk28M35R67t1HwJlsxzI5bn X-Received: by 2002:a9d:7dc9:: with SMTP id k9mr43383083otn.117.1582625125138; Tue, 25 Feb 2020 02:05:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582625125; cv=none; d=google.com; s=arc-20160816; b=hNc6l4hhcoIPxFF39UTR7N/6HCDA6lOZXQRmSVKgZ3jTd4lhE/DhG/bPapQ1gj47tc IPToGEn4iO9w1DALQgeb7438XwozHbm6ri/sBNgmnCnNt3UH4JiyWhkBzjHJVBS/yq6l GCU1S1R3Ok5VGlFrTEy7cn/pswHT8KdVlJo34Jqkc3nVQ5nz5KbMkUVmmAmeM129g9Tr r6K5ETdD63wnTO2n0SbjcZmfE502VFo49MFnuz5k1giL64HJCchyT1b8IAGMEi8PKj+Z xTjIH1CtzoL0WSYPk+g5X9vKKzHa6IY2V1brO9MG8QximjX0DLzwHJo5q3iEmZvtww/+ HlZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from; bh=DXvf4j96l957ii5IgxSstqBFHLUsNWzdiL/4ribmGBQ=; b=QFYkVC2VWYYV4HcSb1zcP+DwMYDimzBpe+sYiTeV8f1Kfsg+87CCaBcCld1wN/5en1 JXlBsTDVFmqpYknQIbh0FUPt+qTYqg07ZHU6PF7j9wfuKorVHvIRA/P1t5KvxIEQjNIB QhmRrI/QIxTLDr8+4SuTbFhZvgVzfEEKK0JYVkY8KpcRLVizzll9VQogioU+0gJXTyIE qHuWG5Ht5S/FF8SNE+KRDY5lihRYF5Y2dsrG050l5v4LMwXx3sSY5mbqSRYzw9N6Ig6w DN4+dAja6c2WMA0XGj+CTpVpjH1CgcV7hAKQgzfSHGmmWDFfaQUE1wIuTDbDZMxeq0Jr Gr1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=YmXZK+2W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l21si6586592oic.126.2020.02.25.02.05.11; Tue, 25 Feb 2020 02:05:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=YmXZK+2W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729925AbgBYKEi (ORCPT + 99 others); Tue, 25 Feb 2020 05:04:38 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:16887 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729623AbgBYKEi (ORCPT ); Tue, 25 Feb 2020 05:04:38 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 25 Feb 2020 02:03:20 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 25 Feb 2020 02:04:37 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 25 Feb 2020 02:04:37 -0800 Received: from [10.21.133.51] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 25 Feb 2020 10:04:35 +0000 From: Jon Hunter Subject: Re: LKFT: arm x15: mmc1: cache flush error -110 To: Ulf Hansson , Bitan Biswas , Adrian Hunter CC: Naresh Kamboju , Jens Axboe , Alexei Starovoitov , linux-block , , open list , "linux-mmc@vger.kernel.org" , Arnd Bergmann , John Stultz , Thierry Reding References:

Message-ID: <6523119a-50ac-973a-d1cd-ab1569259411@nvidia.com> Date: Tue, 25 Feb 2020 10:04:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582625001; bh=DXvf4j96l957ii5IgxSstqBFHLUsNWzdiL/4ribmGBQ=; h=X-PGP-Universal:From:Subject:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=YmXZK+2Wxv4hJ3z1ofqFDa+CdPVumvTk7rk9zzFJ4nsH2sVpgrCIgkpLlbZmTbwwy KWJDi1uXeivi46vK7RPEy60oyQ2Igq5bJ3pAvcrxxbkdHRI5eOBSu06CO9CdnPCSo4 uEx+TFt7QgwAT2UH14svOMSeb1vXqvuy6ZZx6rlm2WpnawaE0BqXhIj7eNHImOdaIb jsTeJGCWSKV+uAc2lG+mrupgiBxd6ZeDpvEg9OQY64KG6RD6J2sJZHPhn6E+pk4Byh lTmEvTxv0MbDlejw7aVjxEP0yBIbeqF5GmbvS+pmL43jkw3WEBTK0e3+n92/GsoZ1K rXu4T/sni80xg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/2020 11:16, Ulf Hansson wrote: > + Adrian > > On Fri, 21 Feb 2020 at 20:44, Bitan Biswas wrote: >> >> On 2/21/20 1:48 AM, Ulf Hansson wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On Thu, 20 Feb 2020 at 18:54, Naresh Kamboju wrote: >>>> >>>> On Wed, 19 Feb 2020 at 21:54, Ulf Hansson wrote: >>>>> >>>>> On Thu, 13 Feb 2020 at 16:43, Naresh Kamboju wrote: >>>>>> >>>>> >>>>> Try to restore the value for the cache flush timeout, by updating the >>>>> define MMC_CACHE_FLUSH_TIMEOUT_MS to 10 * 60 * 1000". >>>> >>>> I have increased the timeout to 10 minutes but it did not help. >>>> Same error found. >>>> [ 608.679353] mmc1: Card stuck being busy! mmc_poll_for_busy >>>> [ 608.684964] mmc1: cache flush error -110 >>>> [ 608.689005] blk_update_request: I/O error, dev mmcblk1, sector >>>> 4302400 op 0x1:(WRITE) flags 0x20800 phys_seg 1 prio class 0 >>>> >>>> OTOH, What best i could do for my own experiment to revert all three patches and >>>> now the reported error gone and device mount successfully [1]. >>>> >>>> List of patches reverted, >>>> mmc: core: Specify timeouts for BKOPS and CACHE_FLUSH for eMMC >>>> mmc: block: Use generic_cmd6_time when modifying >>>> INAND_CMD38_ARG_EXT_CSD >>>> mmc: core: Default to generic_cmd6_time as timeout in __mmc_switch() Reverting all the above also fixes the problem for me. >> I find that from the commit the changes in mmc_flush_cache below is >> the cause. >> >> ## >> @@ -961,7 +963,8 @@ int mmc_flush_cache(struct mmc_card *card) >> (card->ext_csd.cache_size > 0) && >> (card->ext_csd.cache_ctrl & 1)) { >> err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, >> - EXT_CSD_FLUSH_CACHE, 1, 0); >> + EXT_CSD_FLUSH_CACHE, 1, >> + MMC_CACHE_FLUSH_TIMEOUT_MS); I no longer see the issue on reverting the above hunk as Bitan suggested but now I see the following (which is expected) ... WARNING KERN mmc1: unspecified timeout for CMD6 - use generic > Just as a quick sanity test, please try the below patch, which > restores the old cache flush timeout to 10min. > > However, as I indicated above, this seems to be a problem that needs > to be fixed at in the host driver side. For the sdhci driver, there is > a bit of a tricky logic around how to deal with timeouts in > sdhci_send_command(). My best guess is that's where we should look > more closely (and I am doing that). > > From: Ulf Hansson > Date: Mon, 24 Feb 2020 11:43:33 +0100 > Subject: [PATCH] mmc: core: Restore busy timeout for eMMC cache flushing > > Signed-off-by: Ulf Hansson > --- > drivers/mmc/core/mmc_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c > index da425ee2d9bf..713e7dd6d028 100644 > --- a/drivers/mmc/core/mmc_ops.c > +++ b/drivers/mmc/core/mmc_ops.c > @@ -21,7 +21,7 @@ > > #define MMC_OPS_TIMEOUT_MS (10 * 60 * 1000) /* 10min*/ > #define MMC_BKOPS_TIMEOUT_MS (120 * 1000) /* 120s */ > -#define MMC_CACHE_FLUSH_TIMEOUT_MS (30 * 1000) /* 30s */ > +#define MMC_CACHE_FLUSH_TIMEOUT_MS (10 * 60 * 1000) /* 10min */ This does not fix the problem for me. Jon -- nvpublic