Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200225063930.106436-1-chenzhou10@huawei.com> <CAHmME9rWq+jJk5s+OoQ+MFMg74=b-a+LtJFjNWqLg6fcreLKbA@mail.gmail.com>
In-Reply-To: <CAHmME9rWq+jJk5s+OoQ+MFMg74=b-a+LtJFjNWqLg6fcreLKbA@mail.gmail.com>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Tue, 25 Feb 2020 18:08:48 +0800
Message-ID: <CAHmME9pr0CEiztk11GMJS3MFhQkAmeUPkM-uHR06_ataw+SpBg@mail.gmail.com>
Subject: Re: [PATCH -next] drivers: net: WIREGUARD depends on IPV6
To:     Chen Zhou <chenzhou10@huawei.com>
Cc:     David Miller <davem@davemloft.net>, jiri@mellanox.com,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 25, 2020 at 2:52 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> On 2/25/20, Chen Zhou <chenzhou10@huawei.com> wrote:
> > If CONFIG_IPV6 is n, build fails:
> >
> > drivers/net/wireguard/device.o: In function `wg_xmit':
> > device.c:(.text+0xb2d): undefined reference to `icmpv6_ndo_send'
> > make: *** [vmlinux] Error 1
> >
> > Set WIREGUARD depending on IPV6 to fix this.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> > ---
> >  drivers/net/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 25a8f93..824292e 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -74,7 +74,7 @@ config DUMMY
> >  config WIREGUARD
> >       tristate "WireGuard secure network tunnel"
> >       depends on NET && INET
> > -     depends on IPV6 || !IPV6
> > +     depends on IPV6
>
> Thanks for reporting the breakage. However, this is not the correct
> fix, as wireguard should work without IPv6. Rather, the recent icmp
> fixes changed something. I'll investigate why when I'm off the road in
> several hours.

Off the road. Fix posted to mailing list:
https://lore.kernel.org/netdev/20200225100535.45146-1-Jason@zx2c4.com/