Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v1 3/3] nvmem: Remove .read_only field from nvmem_config
Thread-Topic: [PATCH v1 3/3] nvmem: Remove .read_only field from nvmem_config
Thread-Index: AQHV6znsaiedl+y69kCc/s7T8T7K26grvAoA
Date:   Tue, 25 Feb 2020 10:49:33 +0000
Message-ID: <PSXP216MB043889D5ADEC4E9BF36CC3E080ED0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
References: <PSXP216MB043899D4B8F693E1E5C3ECCE80EC0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <PSXP216MB043836D392E998FB3193568480EC0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
In-Reply-To: <PSXP216MB043836D392E998FB3193568480EC0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
Accept-Language: en-AU, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [7IfO7nLqaxZImDa85kH7lfQ1tqE+KIQPMJO1benPlqaCVj//+qVHHlzC8YVYIhq4]
x-microsoft-original-message-id: <20200225104926.GA1683@nicholas-dell-linux>
x-ms-publictraffictype: Email
x-incomingheadercount: 50
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 8af5d47a-4a84-42b3-70ed-08d7b9e065c0
x-ms-traffictypediagnostic: PU1APC01HT170:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QJsvqarFIe8Tchsvj3sGfKNRR7g6+SrhE5AkxXmH53g+objHOFm56G+42zKL0pNfr3niYWV1VUzTQ+JTtg7C8qwaeSIVKxvP4SrruXxUNvUaK5tuh1hNQhyu6ndKUGm1a57GEWHQCDdiXKVlY3n+ZFLu022L1RslcSTBIwYIIh89KoUQIOeKcoECZzkL8hea9W8FDsstpFjBVNX5joIdRmV7og2kh9PiDGJSc+jANPc=
x-ms-exchange-antispam-messagedata: ZMKsoIf3l7WalJQpB/aKaPwT03TJBh+uEtlvF9vQk0IIJTOZem3GAFFgWIzqsh5IGAKpzScFCVpvlXErsM9aC6sewim37H6mU7PTZdXi2fYhk4YkhEPVRc1UyhUpZwjZWRILUyqcj5XOyuYfcxOQBtBz67/dUTfcT/Nj/oX7nGWrcmxniDQzdwWIPtkMXjjSnEY8tXrbYjF381FTjsKGpA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CF4233F167195947A027F4B824CD339F@KORP216.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 8af5d47a-4a84-42b3-70ed-08d7b9e065c0
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2020 10:49:33.8373
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1APC01HT170
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 24, 2020 at 05:43:29PM +0000, Nicholas Johnson wrote:
> There is no .write_only field in nvmem_config, so having .read_only
> makes no sense. We can determine the attrs based on whether .reg_read
> and .reg_write are provided. Using only .reg_read and .reg_write means
> that there can no longer be contradictions (for instance, if .read_only
> is set but .reg_read is NULL).
> 
> Remove .read_only field from nvmem_config.
> 
> Remove all references to .read_only field from drivers.
> 
> Update drivers to only supply nvmem->reg_write if write attrs are
> desired.
> 
> Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
> ---

Sorry all, I got this build bot [0] telling me that this patch 3/3 fails 
to compile for ARM architecture. It worked for x86-64. So please ignore 
3/3 for now while I investigate. 1/3 and 2/3 are all good.

I will find a better way to ensure that I have all of the references and 
post a PATCH v2 sometime.

Kind regards,
Nicholas

[0]
https://lore.kernel.org/lkml/202002250920.gc0wDekv%25lkp@intel.com/