Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3643507ybv; Tue, 25 Feb 2020 04:57:22 -0800 (PST) X-Google-Smtp-Source: APXvYqzB4O606GTJ2Myo7dgre1gSHuu61xBqp4IaGxYEE4M+dA4/1A2RDMpG2/f6K4MNlrDFFMkE X-Received: by 2002:aca:3805:: with SMTP id f5mr3429950oia.6.1582635442172; Tue, 25 Feb 2020 04:57:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582635442; cv=none; d=google.com; s=arc-20160816; b=IA7pL2braxr1UYTrK4wLdp3Kib0+/jcGOJCf0dm9R2sr1neb+b7uPsKuMz967Avk+x zgEf3OJDCkV1OMHHuUZO1ZtPZXRfNWTujRPc+qavAXJ6KpjEPOh7rhy8y1+jtRFjfdo4 atpGLbYSJ6lRLjcxARsDucp0MvjZXnHu4AlqzT4i20gDMex4jG99rItRG6pW8BDwNfwh +NjiLeJv7tfX2UFDBYzJrkkIbILBRgfchEROqPwqFe//acyUTYfb6Rdq82mAMQ/OD8Pk l5/AoS2QJnvO7qpTe/GALwDRMtlVjxTd49FO4rik8SDy+fSHM/AxtmcWbkFsAWugRFgZ s2UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LxJRF/3DQ3H1yy8icaMkIp8Tr+wm3GuISrvUJdxrblo=; b=ABytZsBSmuDDlHAyzryDx9F7G23UDz5d3Auz0lBeNeb0nkOTJBN7xxwoyYzEubLMGq KG4l+rt7k/4ZsQK49emIBqnX/6xIlC/PxpW08O+vsJXBZfX5ipZiWUs0MOK/QApTfAGH OVPWk/N9aXODFVgNOBflySX5tmZFFbLN8EhsaohCgssh+AoGYeG721jDUN2K7GKv139Q soedHolkjMfhp84ze8TqUyBgEbdG/9tX65VDlmajZIaz4uhZ3IWCCYiUdHYZ1Lu42BZO 4M+r4J6H6j7PSylLSLtV+kR4Rh5ncLfHMlKQwKtnSCXynFlOZDDhl03X8Tff5V7QQ7eH /Vfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p25si7535480oto.191.2020.02.25.04.57.09; Tue, 25 Feb 2020 04:57:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729537AbgBYM4d (ORCPT + 99 others); Tue, 25 Feb 2020 07:56:33 -0500 Received: from mga11.intel.com ([192.55.52.93]:35478 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgBYM4c (ORCPT ); Tue, 25 Feb 2020 07:56:32 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2020 04:56:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,484,1574150400"; d="scan'208";a="350143671" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 25 Feb 2020 04:56:30 -0800 Received: by lahna (sSMTP sendmail emulation); Tue, 25 Feb 2020 14:56:29 +0200 Date: Tue, 25 Feb 2020 14:56:29 +0200 From: Mika Westerberg To: Nicholas Johnson Cc: "linux-kernel@vger.kernel.org" , Srinivas Kandagatla Subject: Re: [PATCH v1 2/3] Revert "thunderbolt: Prevent crash if non-active NVMem file is read" Message-ID: <20200225125629.GB2667@lahna.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 05:43:05PM +0000, Nicholas Johnson wrote: > This reverts commit 03cd45d2e219301880cabc357e3cf478a500080f. > > Since commit cd76ed9e5913 ("nvmem: add support for write-only > instances"), this work around is no longer required, so drop it. I don't think you can refer commits that only exists in your local tree. I would just say that "since NVMem subsystem gained support for write-only instances this workaround is not needed anymore" or somesuch. Otherwise this looks good to me, no objections and thanks for doing this :)