Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests/timers: Turn off timeout setting
To:     Po-Hsu Lin <po-hsu.lin@canonical.com>,
        linux-kselftest@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, sboyd@kernel.org, tglx@linutronix.de,
        john.stultz@linaro.org, shuah <shuah@kernel.org>
References: <20200225101809.9986-1-po-hsu.lin@canonical.com>
From:   shuah <shuah@kernel.org>
Message-ID: <bbc88e24-835b-2b1e-2997-255896b14cc4@kernel.org>
Date:   Tue, 25 Feb 2020 08:30:41 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200225101809.9986-1-po-hsu.lin@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/25/20 3:18 AM, Po-Hsu Lin wrote:
> Tests in timers especially nsleep-lat, set-timer-lat,
> inconsistency-check and raw_skew these 4 tests can take longer than
> the default 45 seconds that introduced in commit 852c8cbf
> (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
> 
> Disable the timeout setting for timers instead of looking for an proper
> value to make it more general.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>   tools/testing/selftests/timers/settings | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 100644 tools/testing/selftests/timers/settings
> 
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
> 

What happens when you disable this and set it to 0? How long does the
rest run in this case? Can you add the details to the change log please.

thanks,
-- Shuah