Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v1 2/3] Revert "thunderbolt: Prevent crash if non-active
 NVMem file is read"
Thread-Topic: [PATCH v1 2/3] Revert "thunderbolt: Prevent crash if non-active
 NVMem file is read"
Thread-Index: AQHV6zneI6K1RjwByk+TFt04XZDxaagr34qAgAArsoA=
Date:   Tue, 25 Feb 2020 15:33:00 +0000
Message-ID: <PSXP216MB04387341897FDF77424BE82D80ED0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
References: <PSXP216MB043899D4B8F693E1E5C3ECCE80EC0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <PSXP216MB04383751C15C4D66B59335DA80EC0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <20200225125629.GB2667@lahna.fi.intel.com>
In-Reply-To: <20200225125629.GB2667@lahna.fi.intel.com>
Accept-Language: en-AU, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [CX/MIC/nSBxU82IOwMtvAfa+byOyhHxOHWourM0WcilCrNOVI+SmJqs0eLgKtoVx]
x-microsoft-original-message-id: <20200225153253.GC1740@nicholas-dell-linux>
x-ms-publictraffictype: Email
x-incomingheadercount: 50
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 75895552-6aa7-4ffe-7c61-08d7ba07feba
x-ms-traffictypediagnostic: HK2APC01HT032:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7CyW+crcjpnRR5jHgHUGmqoXcr4hWG6kjlbVLYPF+cmNIIWaXegw+6BM5Zt90/gEjXBKP2fYM1upoRmEz2zmrrX+ZHQIBPttMAu1JVncgKTCf047Gv2PDyQT/Le+gpizcwhKKGDGZ3fdzSG0CMsP3A8agD9z8R2T3EMIDA12pcd+oHl4myE58oXlZ/fuGdYH
x-ms-exchange-antispam-messagedata: YT8l0dgaWC9q6E2bnHS8CJ0rwSPOLRVdqZklRV7KmQJCsDo1PN5uH/qvaEA46hp28BP3xeKimYEJCjqa4MVZVWgyftP/+ukfyjK8FoGXvszZZFR/HeWsxx6wNVct8sd9Nd65m1Dl4qHY/iL2Ff0/9VhhYXMa8Fn9ZdCMXPBBsVQyaGC95lpHMF6vzo7lez1uafU9XzmOCXJxze7IXdS/4Q==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <613B6465DA9E164AB5C884B14D654E22@KORP216.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 75895552-6aa7-4ffe-7c61-08d7ba07feba
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2020 15:33:00.0634
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT032
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 25, 2020 at 02:56:29PM +0200, Mika Westerberg wrote:
> On Mon, Feb 24, 2020 at 05:43:05PM +0000, Nicholas Johnson wrote:
> > This reverts commit 03cd45d2e219301880cabc357e3cf478a500080f.
> > 
> > Since commit cd76ed9e5913 ("nvmem: add support for write-only
> > instances"), this work around is no longer required, so drop it.
> 
> I don't think you can refer commits that only exists in your local tree.
> I would just say that "since NVMem subsystem gained support for
> write-only instances this workaround is not needed anymore" or somesuch.
Are the commit hashes changed when applied to the kernel? If so, oops!

I will remove it in PATCH v2.
> 
> Otherwise this looks good to me, no objections and thanks for doing this :)
Glad I can be of help. :)