Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 25 Feb 2020 16:17:08 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     Heyi Guo <guoheyi@huawei.com>
Cc:     linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH] irq-gic-v3-its: fix access width for gicr_syncr
In-Reply-To: <20200225090023.28020-1-guoheyi@huawei.com>
References: <20200225090023.28020-1-guoheyi@huawei.com>
Message-ID: <740ba8790b72a42d400cc9fc317c4dba@kernel.org>
User-Agent: Roundcube Webmail/1.3.10
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-02-25 09:00, Heyi Guo wrote:
> GICR_SYNCR is a 32bit register, so it is better to access it with
> 32bit access width, though we have not seen any real problem.
> 
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>
> 
> ---
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c 
> b/drivers/irqchip/irq-gic-v3-its.c
> index 65a11257d220..5c6790e3bfbf 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1321,7 +1321,7 @@ static void lpi_write_config(struct irq_data *d,
> u8 clr, u8 set)
> 
>  static void wait_for_syncr(void __iomem *rdbase)
>  {
> -	while (gic_read_lpir(rdbase + GICR_SYNCR) & 1)
> +	while (readl_relaxed(rdbase + GICR_SYNCR) & 1)
>  		cpu_relax();
>  }

Yup, nice catch. Looks like no implementation really cares about it,
but still worth fixing.

I'll take it for 5.7.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...