Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3851797ybv; Tue, 25 Feb 2020 08:25:16 -0800 (PST) X-Google-Smtp-Source: APXvYqxKgqafBn+WYMzlTmQglsCJHyBwWA53vG0y1Z4+DSAUakXA/2W4IgZmOAWIr+G4gpk7bkgF X-Received: by 2002:aca:4306:: with SMTP id q6mr4256388oia.54.1582647916335; Tue, 25 Feb 2020 08:25:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582647916; cv=none; d=google.com; s=arc-20160816; b=qY1oo7fRtvcwkSBcETnqU3+Fqsd6SC+KHBoDSjNn/a9cHEERTtXrZLgkD6T2esgpL7 6B5OnWwAeVSqEn05LHm/XqVzRIer9CVWihdG2oxE9kLbXtuFxE4lEGLzXBdGzY2Hqe2O NqGCDeV6gkllVeSft1b6xaQmSzJA6SwpqwQ+GRi7r+a2AjdyuZJbntoLc9q2KkDYHnlg jocEGQlfEhxX90heCZZsu1R4pWpI4PquXj46TfhlUC6SltGZ3EI4g3rn2dn1n++qK3VC aGL0u5AU/9DThSjXwZtsr/275KfHgoR06wQaxJPRHa3zLdIe9rQJDKC46229ytsFCtWz RfWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=d+k2oADQBKeJHCExPW9X42DfdEf4wTEDT/QfdHMU5IM=; b=tMRwdV3Whfc406dT5DBP0BnMU7Z0mh0wxy80jgsQeHNUF3nILz7llu/VF9J/nGDI+p acoDsYC6yta268qUIp8oebVjcCvgkvVh6TQJk7rEiMrocTsgdGFPICKiRaFQQIveWePp LAy4mhsqYaB89aE98O9zoo783ADpEOy98sG1NnkqUlg1lnhSIa0Lw6uOK9lJdu8YtvfQ kKCkp8IyW21iWyEEnfQyoAAdHAic+EHUkX8/+DpGHH036n6RJepde0Xb+d2T2gBjH1cJ D7uqEjHwdjq+1HCvLm3oaemFMU9CV/VNgE9lI49aqdrl1mxw5CJHvFoOL/anQuZ2c60k qBIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=kWdhcXQK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6si6540175oih.217.2020.02.25.08.25.04; Tue, 25 Feb 2020 08:25:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=kWdhcXQK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730879AbgBYQYq (ORCPT + 99 others); Tue, 25 Feb 2020 11:24:46 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:14686 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729817AbgBYQYp (ORCPT ); Tue, 25 Feb 2020 11:24:45 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 25 Feb 2020 08:24:31 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 25 Feb 2020 08:24:44 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 25 Feb 2020 08:24:44 -0800 Received: from [10.21.133.51] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 25 Feb 2020 16:24:41 +0000 Subject: Re: LKFT: arm x15: mmc1: cache flush error -110 To: Ulf Hansson , Faiz Abbas , Sowjanya Komatineni CC: Bitan Biswas , Adrian Hunter , Naresh Kamboju , "Jens Axboe" , Alexei Starovoitov , linux-block , , open list , "linux-mmc@vger.kernel.org" , Arnd Bergmann , John Stultz , Thierry Reding References: <6523119a-50ac-973a-d1cd-ab1569259411@nvidia.com> From: Jon Hunter Message-ID: <0963b60f-15e7-4bc6-10df-6fc8003e4d42@nvidia.com> Date: Tue, 25 Feb 2020 16:24:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582647871; bh=d+k2oADQBKeJHCExPW9X42DfdEf4wTEDT/QfdHMU5IM=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=kWdhcXQKSJH4GXa6xSkXVhbj0mroRtOyJ6fnisSE9GfHmcEkd+fFWgatHxHs9IYib TIT861jiVMWct2KGXdBFUnuz93ncHEEos7SfypX0n4Lb8z+0RL8QGT5xJWD75wupir yz0sPoHdlKRuA1JlUgef7zx/r24mxhiIiuTPFFT08JwydZt+Skpkum8t5c6F2IhzXz jKEYhTQyc2xHXPD8GHsN18TntYROuk+3yZd/5IUGoCfMszcdk9oFv4u+4gyjxVaEeZ 0EFR+RoPiIATIToqWkAMtrrtqId6IKNMS08ObahXZPI9ib6XI09J9/cGGQcqlsu8zP VP3GAeLJ37K4g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/02/2020 14:26, Ulf Hansson wrote: ... > However, from the core point of view, the response is still requested, > only that we don't want the driver to wait for the card to stop > signaling busy. Instead we want to deal with that via "polling" from > the core. > > This is a rather worrying behaviour, as it seems like the host driver > doesn't really follow this expectations from the core point of view. > And mmc_flush_cache() is not the only case, as we have erase, bkops, > sanitize, etc. Are all these working or not really well tested? I don't believe that they are well tested. We have a simple test to mount an eMMC partition, create a file, check the contents, remove the file and unmount. The timeouts always occur during unmounting. > Earlier, before my three patches, if the provided timeout_ms parameter > to __mmc_switch() was zero, which was the case for > mmc_mmc_flush_cache() - this lead to that __mmc_switch() simply > ignored validating host->max_busy_timeout, which was wrong. In any > case, this also meant that an R1B response was always used for > mmc_flush_cache(), as you also indicated above. Perhaps this is the > critical part where things can go wrong. > > BTW, have you tried erase commands for sdhci tegra driver? If those > are working fine, do you have any special treatments for these? That I am not sure, but I will check. Cheers Jon -- nvpublic