Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200225101809.9986-1-po-hsu.lin@canonical.com> <bbc88e24-835b-2b1e-2997-255896b14cc4@kernel.org>
In-Reply-To: <bbc88e24-835b-2b1e-2997-255896b14cc4@kernel.org>
From:   Po-Hsu Lin <po-hsu.lin@canonical.com>
Date:   Wed, 26 Feb 2020 00:26:40 +0800
Message-ID: <CAMy_GT_aUvyUGb8RhdWu5VQ7Y-a82-Jm4hY7fPGL+rEAityyhw@mail.gmail.com>
Subject: Re: [PATCH] selftests/timers: Turn off timeout setting
To:     shuah <shuah@kernel.org>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        sboyd@kernel.org, tglx@linutronix.de,
        John Stultz <john.stultz@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sure,
I will send V2 that include the change for makefile and more detail
about the change.
Thanks for the feedback,

On Tue, Feb 25, 2020 at 11:30 PM shuah <shuah@kernel.org> wrote:
>
> On 2/25/20 3:18 AM, Po-Hsu Lin wrote:
> > Tests in timers especially nsleep-lat, set-timer-lat,
> > inconsistency-check and raw_skew these 4 tests can take longer than
> > the default 45 seconds that introduced in commit 852c8cbf
> > (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
> >
> > Disable the timeout setting for timers instead of looking for an proper
> > value to make it more general.
> >
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> > ---
> >   tools/testing/selftests/timers/settings | 1 +
> >   1 file changed, 1 insertion(+)
> >   create mode 100644 tools/testing/selftests/timers/settings
> >
> > diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> > new file mode 100644
> > index 0000000..e7b9417
> > --- /dev/null
> > +++ b/tools/testing/selftests/timers/settings
> > @@ -0,0 +1 @@
> > +timeout=0
> >
>
> What happens when you disable this and set it to 0? How long does the
> rest run in this case? Can you add the details to the change log please.
>
> thanks,
> -- Shuah