Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4020876ybv; Tue, 25 Feb 2020 11:36:14 -0800 (PST) X-Google-Smtp-Source: APXvYqzxJnplt64VXp2mZOBhKadtkCcVoy1UzxllQvBdntME2Jq6f8s3zGlxu7jR7KQvgwDRh7dg X-Received: by 2002:a05:6808:319:: with SMTP id i25mr409220oie.128.1582659374401; Tue, 25 Feb 2020 11:36:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582659374; cv=none; d=google.com; s=arc-20160816; b=bt8OB7aq1tLRY6cKZuwf2Pau7ctVFRqTRk99UnoCgitAeWs6hPs2LufxJIRwf8hF9O 28SDbKyImga/+4PzzV41aOLyfyPueTCfW4+XV+I2/gpAA0du3oKMPEbkqw4tWRQwlQ2j lo3Y1cf+L50Fr/4GUDUtU41Ilz/g4ljOvdnG8SS26AfImv2Mw7VFLnEYHQHLNQB9ldCD lfqoNrQL9e8SV9ihYvX5Fl4aoFWtOeD/FMeYvJrIrohzTjAYmF/Ml+TKeGUI7vSPqfTS +AOcsWpXk76eClhyPRlFrN/o7sOXGEiUl/F3ra4Pps9+gXmaYWLVDEtgNuwsa36p9MQu TiJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=W9ULT/SVeK2JDOEE8Re6ndnouAiqLNE4XvcNJ7bv9JA=; b=sdWgm0/acGlHMoEnPsjLRSebh1AOamfHncH6SO7UoeZzHZyOsnDFJUqoCIQw6oCLiH Y50sSReYg0DYOPPIxWqunlXkdYSnxVVkMVNN1WTvuLbhVc3dgRY4uV/zai3ZAT6p70OU L48nZWqYKmfAlY8PZtX0SddE4xnOdyb3jo+2fKJfCTRimVnoYuu3Nrs133EWD0b9uv8j nnXpHZMkDyj7Tk0w25Nq3F2HG0pOUzctmj/Stz1UMEpoLHY0q/b/6ySBicxYANeSwlFO fCnjngLbKLhZuamupDu+ZuNyITA5GNbyu4Z825/ntYuoQpCYw+ua9+Num/SijdrZwqhH OX3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h138si76229oib.6.2020.02.25.11.36.02; Tue, 25 Feb 2020 11:36:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731409AbgBYT1t (ORCPT + 99 others); Tue, 25 Feb 2020 14:27:49 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:54360 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731270AbgBYT1s (ORCPT ); Tue, 25 Feb 2020 14:27:48 -0500 Received: from localhost ([127.0.0.1] helo=vostro.local) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1j6frr-0001Sp-KB; Tue, 25 Feb 2020 20:27:43 +0100 From: John Ogness To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , lijiang , Peter Zijlstra , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] printk: replace ringbuffer References: <20200205044848.GH41358@google.com> <20200205050204.GI41358@google.com> <88827ae2-7af5-347b-29fb-cffb94350f8f@redhat.com> <20200205063640.GJ41358@google.com> <877e11h0ir.fsf@linutronix.de> <20200205110522.GA456@jagdpanzerIV.localdomain> <87wo919grz.fsf@linutronix.de> <20200214155639.m5yp3rd2t3vdzfj7@pathway.suse.cz> <87blpxbh62.fsf@linutronix.de> <20200217145016.7r6b7i5o6tqkaa2x@pathway.suse.cz> Date: Tue, 25 Feb 2020 20:27:40 +0100 In-Reply-To: <20200217145016.7r6b7i5o6tqkaa2x@pathway.suse.cz> (Petr Mladek's message of "Mon, 17 Feb 2020 15:50:16 +0100") Message-ID: <87lfoqqxg3.fsf@linutronix.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-02-17, Petr Mladek wrote: > Alternative solution would be to get rid of record_print_text() > and use record_print_text_inline() everywhere. It will have some > advantages: > > + _inline() variant will get real testing > + no code duplication > + saving the extra buffer also in console, sysfs, and devkmsg > interface. In preparation for my v2, I implemented this alternate approach. Rather than introducing record_print_text_inline(), I changed record_print_text() to work inline and also it will no longer handle the counting case. The callers of record_print_text() for counting will now call the new counting functions. IMHO it is a nice cleanup and also removes the static printk_record structs for console and syslog. Thanks. John Ogness