Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4108392ybv; Tue, 25 Feb 2020 13:21:52 -0800 (PST) X-Google-Smtp-Source: APXvYqzV2qTo4t+YTXEf7Ik8pwRRBwrDF/Lf5GFckI69Nlghniwo7Vow8KMNHHe6+O5e7u9qTqO5 X-Received: by 2002:a9d:664a:: with SMTP id q10mr431327otm.298.1582665712268; Tue, 25 Feb 2020 13:21:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582665712; cv=none; d=google.com; s=arc-20160816; b=LIwflqycVrEJE8HanoyFm7MCqT0pBRPjNlCpeumakRV58fxjB4RG7P+AbqkP44Lbtd yM0HZWn+2uLY9WolONLICHJ8BtSs0LpfaVnJCvCLFINfP+RmY13IXe5wyf8bsIHEQLqB yVpea+Q7RdtOEr2pjKY6eEqJm7NXbrBbdbaS9Ef0jWWuOpiYIKIl3Ovv4PbrnuXXniKI cWaN4LKYK79Oxs2Gy6I8WUCW0rONOor+0G79UazuL7+0uIsMhb5y8jYt/GHKcige+5bC OK4JVXhJZoJv/GqR58jFqKY+O63qgT9Y2W/GoH/EHKkdHsY9VZyq+7E2vMxQfRT0Tqrr Jl6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=FBm9PPixald/Rk5IbZBNO9/IdboEn7o09ju1FoDssks=; b=G8ubyeOAAp0l+3ze2WDy81+ecTm8KhgNo7jKCBpE9DwwACpnHcQjfoGEzpBWz0Mq0b RZCx/dyLtLTydqa86pkbssuBOBePo/opkHrFZ57smywhgWP8IgvoZ22I7kAgJZbcWtHF EaEMoD+Uutqb8OLK26KTfk86U/kJ5LM0ELPLr+AGocKeL3OaF8+oIfkc/8JAPTz15KDH jr+3NouQ7CWK+OOVpsqo9gISvgQLL2rd8Q7eCbOiqCq4eg2kKIkwBZGv/EvaMsjEYppR E+Fo/ZsPggLkfeUTuruhIDJ0/VAP68EzTv+mllwSUvTaxYyPdLiPgrVkMFGLcfwQkNK3 pMIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si235353oih.187.2020.02.25.13.21.40; Tue, 25 Feb 2020 13:21:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729009AbgBYVUB (ORCPT + 99 others); Tue, 25 Feb 2020 16:20:01 -0500 Received: from isilmar-4.linta.de ([136.243.71.142]:49686 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728753AbgBYVTw (ORCPT ); Tue, 25 Feb 2020 16:19:52 -0500 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.1.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 62A77200AFA; Tue, 25 Feb 2020 21:19:50 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id 1D9C420BDB; Tue, 25 Feb 2020 22:11:04 +0100 (CET) Date: Tue, 25 Feb 2020 22:11:04 +0100 From: Dominik Brodowski To: Brian Gerst Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski Subject: Re: [PATCH v2 4/8] x86, syscalls: Refactor SYS_NI macros Message-ID: <20200225211104.GD3954@light.dominikbrodowski.net> References: <20200224181757.724961-1-brgerst@gmail.com> <20200224181757.724961-5-brgerst@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224181757.724961-5-brgerst@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 01:17:53PM -0500, Brian Gerst wrote: > Pull the common code out from the SYS_NI macros into a new __SYS_NI macro. > Also conditionalize the X64 version in preparation for enabling syscall > wrappers on 32-bit native kernels. Same comment about naming; looks good otherwise. Thanks, Dominik