Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4137347ybv; Tue, 25 Feb 2020 13:59:45 -0800 (PST) X-Google-Smtp-Source: APXvYqxR6V45kqbHE61RzXLGdRVJfmppMreIg++iGJFN+PdmxRNu87wW1oFhrBsTbk6+WvsScPc+ X-Received: by 2002:aca:388:: with SMTP id 130mr740702oid.89.1582667985465; Tue, 25 Feb 2020 13:59:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582667985; cv=none; d=google.com; s=arc-20160816; b=krY1pNTmQLLdC8oOdqb/aYaAGcDOj5lo9/S99qd6wFCuegnhEQxCGOHkIq1Oy4v18q S5ZFOcy5+FUePImFm0J71QuBb0Ol6hGgpvaJ1uo3ZoCKt07k6Q3HucyHp2wqqhqvx8Xq vJOsdmbwNymytKF4pYBLHTMG9wBjoakAdD38Wiz0Ve0B78yJLXtnDiFv9kQe7qQva3Bx ppN5Hub9vneobzDqsE8UoezBoG2bwtenYAYdtD/nQEkhy9VqUBZEUvydGi/8CnE9rIYG kx8j/UFq74h6opY49XBXnqzq4oC70azPpgTLlmudz6aAZUnT0028iLY6y4k/FGsUi8uR Aj3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=tj9vZXGH6iwOFlLa0aRE3J/ZfOTcoZoVX2Drb5kRpPU=; b=q82bXLU4X489PB2UfQUXvuYt9/qvAcVdAaya/If3rGS1HJ8MzN3jAlFT5pUxAGZi3O QBK3iCS+HLwGxXFkbKLFAhK4oQ4wRjHWMiE0Mg7p/0ScFgRekGkk7uHh/2ERFY2mo7w2 Qu+fC1utkL5jwFZ0KI2lZh5yJpv38e72gWcufpStYzcsbXcssW39CTdpoojOWO8MuXwy kHWbDQZrBgnxr42TUCKydYl956jTXVLz2NMOk2VGP7I8+Qruh0Ju+9oz12f+W3LdclGO 4duGuALt9zAgi7WKOxEVGomOaM+u4OTQWjm1CFP5i/HPhldGVe0ca3ujvL8LPUdvz255 NbPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si12596oih.187.2020.02.25.13.59.33; Tue, 25 Feb 2020 13:59:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729093AbgBYV7P (ORCPT + 99 others); Tue, 25 Feb 2020 16:59:15 -0500 Received: from www62.your-server.de ([213.133.104.62]:54314 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbgBYV7P (ORCPT ); Tue, 25 Feb 2020 16:59:15 -0500 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1j6iEO-0003fq-6M; Tue, 25 Feb 2020 22:59:08 +0100 Received: from [85.7.42.192] (helo=pc-9.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j6iEN-000Noq-ND; Tue, 25 Feb 2020 22:59:07 +0100 Subject: Re: [PATCH bpf-next v6 0/2] virtio_net: add XDP meta data support To: Yuya Kusakabe , jasowang@redhat.com Cc: andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, davem@davemloft.net, hawk@kernel.org, john.fastabend@gmail.com, kafai@fb.com, kuba@kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com References: <20200225033103.437305-1-yuya.kusakabe@gmail.com> From: Daniel Borkmann Message-ID: <4ae12070-b6ed-af69-52ec-995d59242a42@iogearbox.net> Date: Tue, 25 Feb 2020 22:59:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200225033103.437305-1-yuya.kusakabe@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25734/Tue Feb 25 15:06:17 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/20 4:31 AM, Yuya Kusakabe wrote: > This patch series has 2 patches. > > Patch 1/2: keep vnet header zeroed if XDP is loaded for small buffer > With this fix, we do not need to care about vnet header in XDP meta data > support for small buffer, even though XDP meta data uses in front of > packet as same as vnet header. > It would be best if this patch goes into stable. > This patch is based on the feedback by Jason Wang and Michael S. Tsirkin. > https://lore.kernel.org/netdev/9a0a1469-c8a7-8223-a4d5-dad656a142fc@redhat.com/ > https://lore.kernel.org/netdev/20200223031314-mutt-send-email-mst@kernel.org/ > > Patch 2/2: add XDP meta data support > > Thanks to Jason Wang, Daniel Borkmann and Michael S. Tsirkin for the feedback. > > Yuya Kusakabe (2): > virtio_net: keep vnet header zeroed if XDP is loaded for small buffer > virtio_net: add XDP meta data support > > drivers/net/virtio_net.c | 56 ++++++++++++++++++++++++---------------- > 1 file changed, 34 insertions(+), 22 deletions(-) > Applied, thanks!