Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4444114ybv; Tue, 25 Feb 2020 20:25:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzmgkCQ4flkGdpTEjjWZn8yCI8XXRK7WrUGmE8bUwjUcyCyAG9qAdICRQSdnzW0r49dm7zO X-Received: by 2002:a54:4816:: with SMTP id j22mr1643841oij.179.1582691143152; Tue, 25 Feb 2020 20:25:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582691143; cv=none; d=google.com; s=arc-20160816; b=yN4xp2cAQu+ilUMVv28k/NgkZ6gAdijR/dVfXtHg3t4DCcPWcA2WsNlZP3f0uf8s7Y aElZgQD6VaSzvTuNxXby1tp3jnhEAyp30DqXyJ/soZxxzVyrs28mGptV8Gnj0q3CXb2Q VYMH+O5Gn8/U9cVgvz0Nlo75CBupL3hrrfmG1nWHUo5SxVXhZgmGbLA4X4hthFZcZXCQ zionB3YpDmqxS2pWRAkBMl5BBjYkTjsOwK3dI/31LdD8NEa91PLO++EUDz/sP2FVmetq 0zK9w4Cs0XB7qoTdC7Z/DeUDvuzBUsKJ3rNAihgn0Pp/OJJlTiinkTS2O3SQiMiby8Hw P7qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=o36dHOJ0Re50NAyslHejR3hJoSgx7b7eys6ugOBHCaU=; b=rdz0nJkztbSALwLcv1vpnHFweKLIuhn9QR9qQ0kJFU27LmqXvExsqjPMQ6pQ6M3tnl THgiBuwEfkJX5Mc602DQBJcQGU4aEQzsENZqWSgBE5iA3BDs50OQeTAsIGhrrL1CPmVL VHjyLg+LYBZLKzhCD52qBaMJAVw9ivY7ckVdmdJ0EBq9L+1zMDT/cjxfo2Ea2bcoARxc Xbs20N0/OHgs5MpttL5Mj/MlphdQFJCuWeRsl2dlSSPI/0+MWe2VDB6vMHnU6LGrJ5iX KLI+VLyc/MlH43qTXLbVisroPnHGGbHiEi6LQsWvWb+6BwJsMlV90MZFtCcbM6CpEfis PDZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j2si611466otk.164.2020.02.25.20.25.30; Tue, 25 Feb 2020 20:25:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726277AbgBZEZU (ORCPT + 99 others); Tue, 25 Feb 2020 23:25:20 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:55072 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgBZEZU (ORCPT ); Tue, 25 Feb 2020 23:25:20 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04455;MF=zhangliguang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0TqxCOmx_1582691108; Received: from localhost(mailfrom:zhangliguang@linux.alibaba.com fp:SMTPD_---0TqxCOmx_1582691108) by smtp.aliyun-inc.com(127.0.0.1); Wed, 26 Feb 2020 12:25:17 +0800 From: luanshi To: Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, luanshi Subject: [PATCH] perf: arm_spe: remove unnecessary zero check Date: Wed, 26 Feb 2020 12:25:06 +0800 Message-Id: <1582691106-3432-1-git-send-email-zhangliguang@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "nr_pages" variable has been checked before, it can't be zero, so a check here would be useless. Signed-off-by: Liguang Zhang --- drivers/perf/arm_spe_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index 4e4984a..b72c048 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -831,7 +831,7 @@ static void *arm_spe_pmu_setup_aux(struct perf_event *event, void **pages, * parts and give userspace a fighting chance of getting some * useful data out of it. */ - if (!nr_pages || (snapshot && (nr_pages & 1))) + if (snapshot && (nr_pages & 1)) return NULL; if (cpu == -1) -- 1.8.3.1