Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/5] PCI: endpoint: functions/pci-epf-test: Add DMA
 support to transfer data
To:     Alan Mikhak <alan.mikhak@sifive.com>
CC:     <amurray@thegoodpenguin.co.uk>, <arnd@arndb.de>,
        <bhelgaas@google.com>, <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <lorenzo.pieralisi@arm.com>
References: <20200225091130.29467-1-kishon@ti.com>
 <1582665067-20462-1-git-send-email-alan.mikhak@sifive.com>
From:   Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <7e1202a3-037b-d1f3-f2bf-1b8964787ebd@ti.com>
Date:   Wed, 26 Feb 2020 10:39:13 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <1582665067-20462-1-git-send-email-alan.mikhak@sifive.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Alan,

On 26/02/20 2:41 am, Alan Mikhak wrote:
> @@ -380,6 +572,7 @@ static void pci_epf_test_unbind(struct pci_epf *epf)
>         int bar;
> 
>         cancel_delayed_work(&epf_test->cmd_handler);
> +       pci_epf_clean_dma_chan(epf_test);
>         pci_epc_stop(epc);
>         for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
>                 epf_bar = &epf->bar[bar];
> @@ -550,6 +743,12 @@ static int pci_epf_test_bind(struct pci_epf *epf)
>                 }
>         }
> 
> +       epf_test->dma_supported = true;
> +
> +       ret = pci_epf_init_dma_chan(epf_test);
> +       if (ret)
> +               epf_test->dma_supported = false;
> +
>         if (linkup_notifier) {
>                 epf->nb.notifier_call = pci_epf_test_notifier;
>                 pci_epc_register_notifier(epc, &epf->nb);
> 
> Hi Kishon,
> 
> Looking forward to building and trying this patch series on
> a platform I work on.
> 
> Would you please point me to where I can find the patches
> which add pci_epf_init_dma_chan() and pci_epf_clean_dma_chan()
> to Linux PCI Endpoint Framework?

I've added these functions in pci-epf-test itself instead of adding in
the core files. I realized adding it in core files may not be helpful if
the endpoint function decides to use more number of DMA channels etc.,

Thanks
Kishon