Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4631605ybv; Wed, 26 Feb 2020 00:15:55 -0800 (PST) X-Google-Smtp-Source: APXvYqz/0X+yNJnZ9qK97KBro30KTtfCoJBTmRJP+KfOxREtRNLyIuWOveImyf4f6p3tlhQsKAbo X-Received: by 2002:a05:6830:1d59:: with SMTP id p25mr2099433oth.308.1582704954851; Wed, 26 Feb 2020 00:15:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582704954; cv=none; d=google.com; s=arc-20160816; b=SiHKQjkLxKSeUZ6BYesrQ82KRYydwf5WGoWU0gZbwn1FqIvBOOguTP151pmJ0WbEe0 IwdGmikWzGU9XGWfzde6rIujfbmAOEKUkU7734VonhrYgTa1vA6wyL4c2Kqv118hh7W7 /CeVCJc5CqKrDJQwqvvWPjgUKYQ5QtUhhXpxGw3VstC3inR5FEa5ymjGWAGNQTJkQwBl TqcYoAUCk+Mme6g2rvg2eF4JKd61HzyWblfbg12MQr+enX1gowJt2L2H80s2sYfOQXA/ jLCANSr3yFoS3JCiwud091VudiJeLpI3E0NYiJAWdiA3DN7Y4T/1Hp8Y+DfkP2aqCLRZ q4wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0kjUyzMjeOEz+xsComIMxJTOe6oXb4qqcIYNnmPqXfw=; b=FNoqyj8NNt+IDkX+5ACM7GXvSDs00mH0ywO9nSu9SNeD+zRuuEkj6E7g6rBtZY0IZP sDCn8Tpj+GAjLIK/eOSslsjr6QSv754YcJzfQ9WgEW4ErWeLOsKlWOjcVoXEt7mSobva PXZt2ayYgJxQMA+ifeQ3MwUkQDI43W/ph4PCVbFiEKpKx5iOMAoeFv6gfS1mAfJusf/v LpvKcDhAuhYocHTqHCHyIeeiQ2b8zH25xvEGYmYKMD8LGw6At2IK3xZWK7FPSSvgT8zv 2VRS8zNx2tCMqslP6fGsMy3EOosYa+kjw1hKZ3otlrRFTBSatpKaD5IKRzt+P3zhfns4 BdtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eYNPZ77i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si839987otf.37.2020.02.26.00.15.43; Wed, 26 Feb 2020 00:15:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eYNPZ77i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727487AbgBZIPT (ORCPT + 99 others); Wed, 26 Feb 2020 03:15:19 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:56956 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbgBZIPT (ORCPT ); Wed, 26 Feb 2020 03:15:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0kjUyzMjeOEz+xsComIMxJTOe6oXb4qqcIYNnmPqXfw=; b=eYNPZ77iaJ8rseQhO6rmLzMmfD 666nJ2xoF6m4IWCQOAGKICmRlX48tSUV4/lfLWlnj1TZ5su8tsJgTKYUUOJG11Vl+KEyVAOMVvlUB R1MF/HAiZCgH1XQezlpDjExdfbsDbQjsH/tfPEhviHnCdHn8S01fgmbJVN7E3f/3J8in3KhyxAguD H/9MNJ5zkAaFEzvC9M1PQXEQ5yKaJiChshe4hXgGQ0AoiRwxUO6m/45fqbMmZdJ8701r6lbsL8vDi yBCvxoNMcmwq7eqqI6mwiJ3vsyz2BLbM7GIn/0tsOXF+XFjgYWQ0CqnyvBr0qWrPx3r83aeGfQfk4 Psodjt2Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6rqV-0003zu-US; Wed, 26 Feb 2020 08:15:08 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 673B7300478; Wed, 26 Feb 2020 09:13:10 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C8015203CBB5F; Wed, 26 Feb 2020 09:15:05 +0100 (CET) Date: Wed, 26 Feb 2020 09:15:05 +0100 From: Peter Zijlstra To: Andy Lutomirski Cc: Thomas Gleixner , LKML , x86@kernel.org, Steven Rostedt , Brian Gerst , Juergen Gross , Paolo Bonzini , Arnd Bergmann Subject: Re: [patch 5/8] x86/entry/common: Provide trace/kprobe safe exit to user space functions Message-ID: <20200226081505.GP18400@hirez.programming.kicks-ass.net> References: <20200225220801.571835584@linutronix.de> <20200225221305.719921962@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2020 at 09:45:11PM -0800, Andy Lutomirski wrote: > On 2/25/20 2:08 PM, Thomas Gleixner wrote: > > Split prepare_enter_to_user_mode() and mark it notrace/noprobe so the irq > > flags tracing on return can be put into it. > > Is our tooling clever enough for thsi to do anything? You have a static > inline that is only called in one place, and the caller is notrace and > NOKPROBE. Does this actually allow tracing in the static inline callee? tracing, no, but the NOKPROBE on inline functions is buggered afaiu.