Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1582567352-4664-1-git-send-email-isaacm@codeaurora.org>
In-Reply-To: <1582567352-4664-1-git-send-email-isaacm@codeaurora.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 26 Feb 2020 10:01:37 +0100
Message-ID: <CAMuHMdU-dHU2cjfGHS1c1p-mEfHWb70Ltm697up=ej8-jET=fg@mail.gmail.com>
Subject: Re: [PATCH] of: of_reserved_mem: Increase limit on number of reserved regions
To:     "Isaac J. Manjarres" <isaacm@codeaurora.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Patrick Daly <pdaly@codeaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        lmark@codeaurora.org, Pratik Patel <pratikp@codeaurora.org>,
        Android Kernel Team <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Isaac,

On Mon, Feb 24, 2020 at 7:03 PM Isaac J. Manjarres
<isaacm@codeaurora.org> wrote:
> From: Patrick Daly <pdaly@codeaurora.org>
>
> Certain SoCs need to support a large amount of reserved memory
> regions. For example, Qualcomm's SM8150 SoC requires that 20
> regions of memory be reserved for a variety of reasons (e.g.
> loading a peripheral subsystem's firmware image into a
> particular space).
>
> When adding more reserved memory regions to cater to different
> usecases, the remaining number of reserved memory regions--12
> to be exact--becomes too small. Thus, double the existing
> limit of reserved memory regions.
>
> Signed-off-by: Patrick Daly <pdaly@codeaurora.org>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>

Thanks for your patch!

> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -22,7 +22,7 @@
>  #include <linux/slab.h>
>  #include <linux/memblock.h>
>
> -#define MAX_RESERVED_REGIONS   32
> +#define MAX_RESERVED_REGIONS   64
>  static struct reserved_mem reserved_mem[MAX_RESERVED_REGIONS];
>  static int reserved_mem_count;

This increases the size of reserved_mem[] by 896 (32-bit), 1280 (32-bit LPAE),
or 1792 (64-bit) bytes. While some systems don't need reserved memory
regions at all, and may be RAM-limited.

Perhaps this array can be replaced by some dynamically increasing
structure?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds