Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/2] ASoC: tlv320adcx140: Add the tlv320adcx140 codec
 driver family
To:     Ricard Wanderlof <ricardw@axis.com>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20200219125942.22013-1-dmurphy@ti.com>
 <20200219125942.22013-3-dmurphy@ti.com>
 <alpine.DEB.2.20.2002261138040.19469@lnxricardw1.se.axis.com>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <62c9be55-7ca7-eeaa-52e6-2b93783769a1@ti.com>
Date:   Wed, 26 Feb 2020 06:43:21 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.2002261138040.19469@lnxricardw1.se.axis.com>
Content-Type: text/plain; charset="iso-8859-15"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Richard

On 2/26/20 5:18 AM, Ricard Wanderlof wrote:
> On Wed, 19 Feb 2020, Dan Murphy wrote:
>
>> Add the tlv320adcx140 codec driver family.
>>
> ...
>
>> +
>> +static int adcx140_set_dai_fmt(struct snd_soc_dai *codec_dai,
>> +????????????????????????????? unsigned int fmt)
>> +{
>> +?????? struct snd_soc_component *component = codec_dai->component;
>> +?????? struct adcx140_priv *adcx140 =
>> snd_soc_component_get_drvdata(component);
>> +?????? u8 iface_reg1 = 0;
>> +?????? u8 iface_reg2 = 0;
>> +
>> +?????? /* set master/slave audio interface */
>> +?????? switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
>> +?????? case SND_SOC_DAIFMT_CBM_CFM:
>> +?????????????? iface_reg2 |= ADCX140_BCLK_FSYNC_MASTER;
> Although this sets up the codec to be I2S master, there doesn't seem to be
> a way of actually configuring the master clock frequency in master mode,
> as there is no .set_sysclk member in adcx140_dai_ops (and the
> corresponding register field appears never to be touched by the driver).

Thanks for the comments.? The driver was written for the device to be in 
slave mode with auto clock configuration set.

I will look into adding the master mode clock settings.

>
>> +?????????????? break;
>> +?????? case SND_SOC_DAIFMT_CBS_CFS:
>> +?????????????? break;
>> +?????? case SND_SOC_DAIFMT_CBS_CFM:
>> +?????? case SND_SOC_DAIFMT_CBM_CFS:
>> +?????? default:
>> +?????????????? dev_err(component->dev, "Invalid DAI master/slave interface\n");
>> +?????????????? return -EINVAL;
>> +?????? }
> ...
>
>> +
>> +static int adcx140_codec_probe(struct snd_soc_component *component)
>> +{
>> +?????? struct adcx140_priv *adcx140 =
>> snd_soc_component_get_drvdata(component);
>> +?????? int sleep_cfg_val = ADCX140_WAKE_DEV;
>> +?????? u8 bias_source;
>> +?????? u8 vref_source;
>> +?????? int ret;
>> +
>> +?????? ret = device_property_read_u8(adcx140->dev, "ti,mic-bias-source",
>> +???????????????????????????????????? &bias_source);
>> +?????? if (ret)
>> +?????????????? bias_source = ADCX140_MIC_BIAS_VAL_VREF;
>> +
>> +?????? if (bias_source != ADCX140_MIC_BIAS_VAL_VREF &&
>> +?????????? bias_source != ADCX140_MIC_BIAS_VAL_VREF_1096 &&
>> +?????????? bias_source != ADCX140_MIC_BIAS_VAL_AVDD) {
>> +?????????????? dev_err(adcx140->dev, "Mic Bias source value is invalid\n");
>> +?????????????? return -EINVAL;
>> +?????? }
>> +
>> +?????? ret = device_property_read_u8(adcx140->dev, "ti,vref-source",
>> +???????????????????????????????????? &vref_source);
>> +?????? if (ret)
>> +?????????????? vref_source = ADCX140_MIC_BIAS_VREF_275V;
>> +
>> +?????? if (vref_source != ADCX140_MIC_BIAS_VREF_275V &&
>> +?????????? vref_source != ADCX140_MIC_BIAS_VREF_25V &&
>> +?????????? vref_source != ADCX140_MIC_BIAS_VREF_1375V) {
> According to the data sheet, this setting controls the ADC full scale
> setting and has nothing to do with the mic bias voltage, hence using
> MIC_BIAS as part of the macro name is misleaading.
>
These are not macros they are #defines but in any event I can change the 
names as they are all local to the c and h files.
>> +?????????????? dev_err(adcx140->dev, "Mic Bias source value is invalid\n");
> Error text does not reflect the actual error, suggest "VREF value is
> invalid".

Ack

Dan