Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: ISfsMgCWeWjvN2iZ3+pfRkjPUKan5APG+oMT76BKGRI6RTXjQnVMWwYfE29j1MT/vIyZRKkVAu
 dHGD+tDS0tZS96apxr9OWRISjKx6wLMKuHcJDybMtGUHRRhSTcieuxcstn3hhwg6zNK/31K3Mi
 FbR3hviz45NuZkMzc3cZqxMAYZMwe/nnf3g+LtTqDFSZP+risLSp5aelNRL5ZCP4Cg0d+lIurq
 pHn/HtavGVh2rNMkmG9FsPSsMG3uHsZrXmXR6UBhhFVdthBaBus7ptLCjgHka5dAX8SR1dA8NJ
 8yE=
IronPort-SDR: 0os0INSCuSvWQx3sERMVBzLvQD9YuTMXBt9d68pReAgoDAsRQOY07zrSMuatGi36uM5xgQUeMd
 PBedhtm2A/gjssh1AMAoY6mwD/EwnmtfHCZ+AMFz7051wVA5M9es80l20SlSul+ao9fx1wqtFr
 t/X86WNdOXniz97wgwHL9uuCZoDjiSYuP3LTWo81nYDYqQv/kSWbAEEjNMwSe0R0GONFLZ+5sP
 UjbpBSmvmwUjjIITrYg4JVD61I5IWR3ScYaH+vFK/18Ao36ktVisi9AIbMyuFhT+V0qL3hRtHs
 qqw=
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de
Cc:     linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: [PATCH 3/4] pwm: pca9685: initialize all LED registers during probe
Date:   Wed, 26 Feb 2020 14:52:28 +0100
Message-Id: <20200226135229.24929-3-matthias.schiffer@ew.tq-group.com>
In-Reply-To: <20200226135229.24929-1-matthias.schiffer@ew.tq-group.com>
References: <20200226135229.24929-1-matthias.schiffer@ew.tq-group.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Initialize all ON delays to 0 during probe, rather than doing it in
pca9685_pwm_enable.

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 drivers/pwm/pwm-pca9685.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index 393ab92aa945..370691b21107 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -289,13 +289,6 @@ static int pca9685_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
 {
 	struct pca9685 *pca = to_pca(chip);
 
-	/*
-	 * The PWM subsystem does not support a pre-delay.
-	 * So, set the ON-timeout to 0
-	 */
-	regmap_write(pca->regmap, LED_N_ON_L(pwm->hwpwm), 0);
-	regmap_write(pca->regmap, LED_N_ON_H(pwm->hwpwm), 0);
-
 	/*
 	 * Clear the full-off bit.
 	 * It has precedence over the others and must be off.
@@ -388,6 +381,13 @@ static int pca9685_pwm_probe(struct i2c_client *client,
 	regmap_write(pca->regmap, PCA9685_ALL_LED_OFF_L, 0);
 	regmap_write(pca->regmap, PCA9685_ALL_LED_OFF_H, 0);
 
+	/*
+	 * The PWM subsystem does not support a pre-delay.
+	 * So, set the ON-timeout to 0
+	 */
+	regmap_write(pca->regmap, PCA9685_ALL_LED_ON_H, 0);
+	regmap_write(pca->regmap, PCA9685_ALL_LED_ON_L, 0);
+
 	pca->chip.ops = &pca9685_pwm_ops;
 	pca->chip.npwm = PCA9685_MAXCHAN;
 
-- 
2.17.1