Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4983882ybv; Wed, 26 Feb 2020 06:27:33 -0800 (PST) X-Google-Smtp-Source: APXvYqxkBFb/DnrugZhecH58bXQBmf9QQyIGH1jYS/hXItIx9fb1JliYVjofn+rWZkdO9lz0n25A X-Received: by 2002:a9d:750b:: with SMTP id r11mr3373303otk.310.1582727253645; Wed, 26 Feb 2020 06:27:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582727253; cv=none; d=google.com; s=arc-20160816; b=QgToa5yvNXxhTa4brbQr8xfuksVys0tqamg8/WypAwOlPZ/zNu8p1b38ICHwdCD1ZH xjUFu7WQm3TF6ZSdPEuVxlocInWpKsW+QB3YeaEt4jmsGfcY0jDVPOxdWtgu5//zA3nc WYS0P3BO9r6KD2cKEUx9wL5DOSm+QTgyKSN7HlHbn07qs/NJh/a7saom0zbn4HfZfQ6h DKPExE2J7ikY44YEbV5Bh+KSCBSsMMsAorUHybJuESXSILxxCXLrkUZGtcsA0idhlnTY Ze5wy39JDHji5pFxi+cYRcX6JefL5kyUOMhbjG8zwajVoFyGmtZPSdcf4/S5kmBRxuiH lE9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=hOV3gPwDYXKtOPsZLOxG0uzA4oR/IUdXkCtEXIihxiM=; b=MhRmU2zCJ7pgmYzEFA8IoubaSPNYEJjmtGjYyDIR9efCMNo9w9p2pGsEKp/Nq4wIlc AsKX99G4BY+KiiYgsXkkU1cS49c/1+ZYHhgcTmWVdfk486tTnXt2yF0MFMIs4JqlvZ9e zI36awCdwpHnZrE1ZEY1SPk0PLGa82FihxJJPM4CNzN34xpGNTpewH715hRJHUzqfGdY bzpSQgkOn4kRV5iGqGwp+4OkRPs/ZHBPXnGL+rQykUuRjVyY6D3FWtrNtVCvuWtNZp7u Aa/nQbwXZulS6+ZeLF5eSxWGzjtS53BNCjVoV7wh5fY2+xFLEoXVZTl1fFQpCjgun6LN JctQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=A3EBYdNt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w5si1367923otq.238.2020.02.26.06.27.20; Wed, 26 Feb 2020 06:27:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=A3EBYdNt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbgBZO03 (ORCPT + 99 others); Wed, 26 Feb 2020 09:26:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:38926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727551AbgBZO01 (ORCPT ); Wed, 26 Feb 2020 09:26:27 -0500 Received: from linux-8ccs.suse.de (p5B2812F9.dip0.t-ipconnect.de [91.40.18.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F32924683; Wed, 26 Feb 2020 14:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582727186; bh=I+02811uaLiwUb3AZQBeCUgzyvtIl/KGp1S62hAcdz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A3EBYdNtM+yt9wu0Rj9XNVxzsnlk7qra4+Bg1nFmv5gkcl8TPFt1XXC/LYgUraNoQ u+Hb4IW+skU9X6WzHw2kWk9hteq4bjGWtZc6WeAcD37cgSDksTg4TqJkrZVOQ2xqtM RTfAGUccPMdYeN9KmRXUswWi9TUCTFTaE6Q47xYI= From: Jessica Yu To: Masahiro Yamada Cc: Matthias Maennich , Joe Perches , linux-kernel@vger.kernel.org, Jessica Yu Subject: [PATCH v2 2/2] modpost: return error if module is missing ns imports and MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=n Date: Wed, 26 Feb 2020 15:26:08 +0100 Message-Id: <20200226142608.19499-2-jeyu@kernel.org> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200226142608.19499-1-jeyu@kernel.org> References: <20200226142608.19499-1-jeyu@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently when CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=n, modpost only warns when a module is missing namespace imports. Under this configuration, such a module cannot be loaded into the kernel anyway, as the module loader would reject it. We might as well return a build error when a module is missing namespace imports under CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=n, so that the build warning does not go ignored/unnoticed. Signed-off-by: Jessica Yu --- scripts/Makefile.modpost | 15 ++++++++------- scripts/mod/modpost.c | 14 +++++++++++--- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index b4d3f2d122ac..957eed6a17a5 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -46,13 +46,14 @@ include scripts/Kbuild.include kernelsymfile := $(objtree)/Module.symvers modulesymfile := $(firstword $(KBUILD_EXTMOD))/Module.symvers -MODPOST = scripts/mod/modpost \ - $(if $(CONFIG_MODVERSIONS),-m) \ - $(if $(CONFIG_MODULE_SRCVERSION_ALL),-a) \ - $(if $(KBUILD_EXTMOD),-i,-o) $(kernelsymfile) \ - $(if $(KBUILD_EXTMOD),$(addprefix -e ,$(KBUILD_EXTRA_SYMBOLS))) \ - $(if $(KBUILD_EXTMOD),-o $(modulesymfile)) \ - $(if $(CONFIG_SECTION_MISMATCH_WARN_ONLY),,-E) \ +MODPOST = scripts/mod/modpost \ + $(if $(CONFIG_MODVERSIONS),-m) \ + $(if $(CONFIG_MODULE_SRCVERSION_ALL),-a) \ + $(if $(KBUILD_EXTMOD),-i,-o) $(kernelsymfile) \ + $(if $(KBUILD_EXTMOD),$(addprefix -e ,$(KBUILD_EXTRA_SYMBOLS))) \ + $(if $(KBUILD_EXTMOD),-o $(modulesymfile)) \ + $(if $(CONFIG_SECTION_MISMATCH_WARN_ONLY),,-E) \ + $(if $(CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS)$(KBUILD_NSDEPS),-N) \ $(if $(KBUILD_MODPOST_WARN),-w) ifdef MODPOST_VMLINUX diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 3201a2ac5cc4..d164be63c2e3 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -39,6 +39,8 @@ static int sec_mismatch_count = 0; static int sec_mismatch_fatal = 0; /* ignore missing files */ static int ignore_missing_files; +/* If set to 1, only warn (instead of error) about missing ns imports */ +static int allow_missing_ns_imports = 0; enum export { export_plain, export_unused, export_gpl, @@ -2209,8 +2211,11 @@ static int check_exports(struct module *mod) if (exp->namespace && !module_imports_namespace(mod, exp->namespace)) { - warn("module %s uses symbol %s from namespace %s, but does not import it.\n", - basename, exp->name, exp->namespace); + warn_unless(!allow_missing_ns_imports, + "module %s uses symbol %s from namespace %s, but does not import it.\n", + basename, exp->name, exp->namespace); + if (!allow_missing_ns_imports) + err = 1; add_namespace(&mod->missing_namespaces, exp->namespace); } @@ -2553,7 +2558,7 @@ int main(int argc, char **argv) struct ext_sym_list *extsym_iter; struct ext_sym_list *extsym_start = NULL; - while ((opt = getopt(argc, argv, "i:e:mnsT:o:awEd:")) != -1) { + while ((opt = getopt(argc, argv, "i:e:mnsT:o:awENd:")) != -1) { switch (opt) { case 'i': kernel_read = optarg; @@ -2591,6 +2596,9 @@ int main(int argc, char **argv) case 'E': sec_mismatch_fatal = 1; break; + case 'N': + allow_missing_ns_imports = 1; + break; case 'd': missing_namespace_deps = optarg; break; -- 2.16.4