Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5006892ybv; Wed, 26 Feb 2020 06:52:14 -0800 (PST) X-Google-Smtp-Source: APXvYqzxkIKPOnjxmPz/zWHymoU6/p3FBlj2TtxHzMUs9ghFiyet6yr8smBFjwBDOtGoYVCskDZm X-Received: by 2002:a05:6808:24e:: with SMTP id m14mr3487107oie.168.1582728734303; Wed, 26 Feb 2020 06:52:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582728734; cv=none; d=google.com; s=arc-20160816; b=E/rB83Di5G63TohdawReqrSR4jJA7qdY1CctD2jQchp4ILuWZIhVhNilNtxXll/9A1 OBXKIn7rWzPmqbc7S5Mx5iME0b/y5PjCdb8nXLn7zqL9+RCi4dsyBoMga7dmRhyt/VBb sGWiMUmgDKqGxvp/P2Cdln1rLfuLN4uMP5p5VnQDHrvAYMTKwGIXMVYMWMCAmoY71XA4 0C9BFS99CxvU+a0uQtrPhLWXujMuUYExnhKaXfH0G8aNydAMGznkjfLruG+gZxjmCHdT LdBsAjKZVhWNtShBvI0zbfxJoj67YOR6CfM5mrFm46VaUdBha3h67RVkKFtU+j21OZaT zTPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=l2WBiCb5duYJRA9nKpihqrJOH1Qjg6utSrFiu8qAdtc=; b=r6hQ88Rybk1L6DWJfhP4KBBAyN4nLca+TRiECp8XNhkNSlMgp0407Mrt+cSrAMyN7z 6PzSsc+CBHZTLv/lQpp6Vc+fC/t+iONSDeZnGl3R02pyFjQCI8sjz+MpavzjuZX28RDK kR/OdRUsqUnKzOQ9udXCLlHCWhfMW3uVYnIa1FbRtetu0bIIjyd8JmilWsjG1gVpblMu FeKpjyPiAiol3hftNxKnq3CPPil8cYF4/bNV4HQO45K6JBxToEFHzrN7fyRZadLbKPat f7BLV6cTNKvFhB+Luu8qk0L/LqgXHUcvBNF4cB7m9ch4kf510VR9x0gxy+H/aCkAloFz o51A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UtUC9d7c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si1428638ota.300.2020.02.26.06.52.02; Wed, 26 Feb 2020 06:52:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UtUC9d7c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbgBZOuv (ORCPT + 99 others); Wed, 26 Feb 2020 09:50:51 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43430 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbgBZOuv (ORCPT ); Wed, 26 Feb 2020 09:50:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l2WBiCb5duYJRA9nKpihqrJOH1Qjg6utSrFiu8qAdtc=; b=UtUC9d7cZWT4BRbWaLU+EiTUS1 6+6Kd9gfBrL0gRs1/835RTvbJj2cvx8UJOLuLW/Bb6ES/okhRXF7YGi2X5GNzBTLwP8ZZgemX3RlV hjdulGXTgYSE5cZtMwV5mZGk9lkPbGfddFgpQUt6CcM4v7GZNPsBE/4eqTsA0ZpEhn+N4mX4Mb9Wm K2tELBaH7+KeOg2Ty2eOTxV4SeRcKiTCIF6w347CKoTyz9O7F0gtxGaD0J77R4QuxXOWb1kr/GBAz UZu/L868QpIA2J5dVIVH5+eJA3qYi6cxtd+Ov0n+JCj4SZYKXgnqLPJ64k2pzc5+aO7nf8Ee/kCkK 6WZ+MyGw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6y1Q-0004xx-CO; Wed, 26 Feb 2020 14:50:48 +0000 Date: Wed, 26 Feb 2020 06:50:48 -0800 From: Christoph Hellwig To: Qian Cai Cc: darrick.wong@oracle.com, hch@infradead.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] xfs: fix an undefined behaviour in _da3_path_shift Message-ID: <20200226145048.GA19034@infradead.org> References: <20200226020637.1065-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226020637.1065-1-cai@lca.pw> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig