Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 26 Feb 2020 17:02:55 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Stefan Berger <stefanb@linux.ibm.com>
Cc:     Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux-integrity@vger.kernel.org, aik@ozlabs.ru,
        david@gibson.dropbear.id.au, linux-kernel@vger.kernel.org,
        nayna@linux.vnet.ibm.com, gcwilson@linux.ibm.com, jgg@ziepe.ca
Subject: Re: [PATCH v2 3/4] tpm: Implement tpm2_init to call when
 TPM_OPS_AUTO_STARTUP is not set
Message-ID: <20200226150255.GB3407@linux.intel.com>
References: <20200213202329.898607-1-stefanb@linux.vnet.ibm.com>
 <20200213202329.898607-4-stefanb@linux.vnet.ibm.com>
 <20200225170015.GE15662@linux.intel.com>
 <3813980a-6c5e-c99f-7b37-b20b72eb6a8a@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3813980a-6c5e-c99f-7b37-b20b72eb6a8a@linux.ibm.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 25, 2020 at 01:20:39PM -0500, Stefan Berger wrote:
> On 2/25/20 12:00 PM, Jarkko Sakkinen wrote:
> > On Thu, Feb 13, 2020 at 03:23:28PM -0500, Stefan Berger wrote:
> > > From: Stefan Berger <stefanb@linux.ibm.com>
> > > 
> > > Implement tpm2_init() that gets the TPM 2 timeouts and command durations
> > > and command code attributes. This function is to be called in case the
> > > TPM_OPS_AUTO_STARTUP flag is not set and therefore tpm2_auto_startup()
> > > is not called.
> > > 
> > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> > The commit makes zero effort trying to explain what the heck tpm_init()
> > is and when it should be used and why the function name tpm2_init().
> 
> Are you saying the explanation of when to use tpm2_init above is not enough?
> 'bviously we are trying to cover the case of using the TPM 2 by a driver
> that doesn't use the TPM_OPS_AUTO_STARTUP flag and therefore the TPM 2
> timeouts and command durations and command code attributes are not set as
> they would be if tpm2_auto_startup() was to be called and tpm2_init() is the
> alternative to call. I didn't like tpm2_init() either... any suggestions for
> a better name?

I'm not getting what this commit is trying to do in the first place.

/Jarkko