Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp45652ybf; Wed, 26 Feb 2020 08:33:24 -0800 (PST) X-Google-Smtp-Source: APXvYqwfdMkLIC45jzx7mJ+XnKLmvvDXW5wTmoh/hY1C1X6xvCuQVWn9OY4es2ymiZPel9V+qBbd X-Received: by 2002:aca:ec13:: with SMTP id k19mr3745449oih.22.1582734804786; Wed, 26 Feb 2020 08:33:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582734804; cv=none; d=google.com; s=arc-20160816; b=qhHtJ4wC+qrEiwM64Hg7CZaAH6Ehq4wh4KoRoM6v2kRt8hiCIvdAwMRy2/Wl97ed4D 3oC6zRwu0seIJTmJU10ZRzyKJLGVz/AFN0T8bPGXhxiHQvovJyv7enENYNoEh7E+/n/8 YFFDS/eBPHieqgh09+mwZbiGybSqEWlrt9mDkrrKGLJFWbq7NqjKfcLk18Gajhe4BMGn iXYI8hWdkY6b3Bv2DOHTrCuBWsfZWwUGd6aVDKM2XrX+G6WuQJpfaMP/oK6K3ux58Tfn +cN5FaJV6zPloiJMaCvYjsRQ8ybHWuQrrXllrBdDusnoDRqkuLUiKxY74FkL/GEHaOfT VZIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Z1w+58dOrrZr3wo5mk8rJB/ZJsesTkU2LXg6fDoYot4=; b=IcvyrV5drYoGmsI1bot9r5Syjlrtwv9Km9lT66msP8qtdr4O4J6z++Tg28e+4m2vgM lsCNxqmQE5cji0TyCXlUGZpmunkDHjEx+w6P+sxdhqqMmfyE+VzXMhj2kJV7z/ic2Lzc lzSRZxMcb4q9UpvaAddmiNDW1ZaLfX7oN6bxrXZjwnElxGSfckdYysm1nnGKLouOmMXs MXZAyDkqNVk5tb6ILgtOXHCcM2Q7f0B5s444ADmRYlal7UNSzJCdBhMS4kvd/jSD7x5d SGHkYxSs+M+F2P3zgE+bbOa4OfWgELYY+JgBk+l+ObcMHmZTLOHr8BHSCBhiuCeI+c1b QwBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cumulusnetworks.com header.s=google header.b=PWVHdGOK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cumulusnetworks.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j18si808041oii.42.2020.02.26.08.33.10; Wed, 26 Feb 2020 08:33:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cumulusnetworks.com header.s=google header.b=PWVHdGOK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cumulusnetworks.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727783AbgBZQbg (ORCPT + 99 others); Wed, 26 Feb 2020 11:31:36 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43840 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbgBZQbg (ORCPT ); Wed, 26 Feb 2020 11:31:36 -0500 Received: by mail-ed1-f65.google.com with SMTP id dc19so4482351edb.10 for ; Wed, 26 Feb 2020 08:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z1w+58dOrrZr3wo5mk8rJB/ZJsesTkU2LXg6fDoYot4=; b=PWVHdGOKeZeBrmZqjFNWON3PpXWLD/9F+byeDjIJWy+ytRge7nUh9NGmyX86dkURx+ e0mLG9bX4960huPEWOL+TWR+I1cgCsC/A9WJEuvwqSBaMzaTqV0o7c4/0zm9hdj7F82H URmRnPcaEgXmpKdkbmcIvzfhb5rKpkH41i0l4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z1w+58dOrrZr3wo5mk8rJB/ZJsesTkU2LXg6fDoYot4=; b=CE8BDyhPoNxWQVZcvf3b4VAkktP9DTzFIi2mvd8KGS9Ezh95QBR+r2ATPEMYnRsqYs YE6IfXA8d7WZA1vTihKSIqmnNs4np4CqP7QzFx+KHM9wUFnHvSESeuxHheK11INfhNxb AMGdlIdZ9pPQhAgYG0Cv/JnIBHbZQvP68Efl5SPf3NXpR9zjv0CobCbnHJ7cPg6Wd8k/ VblcDVmm+YF7cOBOgLcQgjq9JZ7X5PpW/b5/iMcm/RLu67kA8MW3A7zyRyX2jF3Qapeg 5qdTHgMxPwyE3ydnev9FJFo5Wsn+hZLWzPX6iew6agt+MOADrub2AhOS5cdNrxMrdfXQ IzHw== X-Gm-Message-State: APjAAAUt0bJjJnuc8T2+h83UhDNt8OZT8fW6rVJkaQgcRm5qiMZIxIAG W0pdznB7RJ6TdUkdknlGfSztJpozLSe5rrhEc7Mb/w== X-Received: by 2002:a17:906:f105:: with SMTP id gv5mr5259642ejb.135.1582734694188; Wed, 26 Feb 2020 08:31:34 -0800 (PST) MIME-Version: 1.0 References: <20200225163025.9430-1-vadym.kochan@plvision.eu> In-Reply-To: <20200225163025.9430-1-vadym.kochan@plvision.eu> From: Roopa Prabhu Date: Wed, 26 Feb 2020 08:38:32 -0800 Message-ID: Subject: Re: [RFC net-next 0/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) To: Vadym Kochan Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "David S . Miller" , Oleksandr Mazur , Taras Chornyi , Serhiy Boiko , Andrii Savka , Volodymyr Mytnyk , David Ahern Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2020 at 8:31 AM Vadym Kochan wrote: > > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely > wireless SMB deployment. > > Prestera Switchdev is a firmware based driver which operates via PCI > bus. The driver is split into 2 modules: > > - prestera_sw.ko - main generic Switchdev Prestera ASIC related logic. > > - prestera_pci.ko - bus specific code which also implements firmware > loading and low-level messaging protocol between > firmware and the switchdev driver. > > This driver implementation includes only L1 & basic L2 support. > > The core Prestera switching logic is implemented in prestera.c, there is > an intermediate hw layer between core logic and firmware. It is > implemented in prestera_hw.c, the purpose of it is to encapsulate hw > related logic, in future there is a plan to support more devices with > different HW related configurations. > > The firmware has to be loaded each time device is reset. The driver is > loading it from: > > /lib/firmware/marvell/prestera_fw_img.bin > > The firmware image version is located within internal header and consists > of 3 numbers - MAJOR.MINOR.PATCH. Additionally, driver has hard-coded > minimum supported firmware version which it can work with: > > MAJOR - reflects the support on ABI level between driver and loaded > firmware, this number should be the same for driver and > loaded firmware. > > MINOR - this is the minimal supported version between driver and the > firmware. > > PATCH - indicates only fixes, firmware ABI is not changed. > > The firmware image will be submitted to the linux-firmware after the > driver is accepted. > > The following Switchdev features are supported: > > - VLAN-aware bridge offloading > - VLAN-unaware bridge offloading > - FDB offloading (learning, ageing) > - Switchport configuration > > CPU RX/TX support will be provided in the next contribution. > > Vadym Kochan (3): > net: marvell: prestera: Add Switchdev driver for Prestera family ASIC > device 98DX325x (AC3x) > net: marvell: prestera: Add PCI interface support > dt-bindings: marvell,prestera: Add address mapping for Prestera > Switchdev PCIe driver > Have not looked at the patches yet, but very excited to see another switchdev driver making it into the kernel!. Thanks Marvell!.