Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS
 SYSC type
To:     Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>
CC:     Tero Kristo <t-kristo@ti.com>, <linux-omap@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
References: <20200225204649.28220-1-s-anna@ti.com>
 <20200225204649.28220-2-s-anna@ti.com>
 <96ec493b-3615-e84d-ba30-cabbf750c874@ti.com>
From:   Suman Anna <s-anna@ti.com>
Message-ID: <b35e278d-c3dd-3356-93c3-0511d3164d7a@ti.com>
Date:   Wed, 26 Feb 2020 10:38:36 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <96ec493b-3615-e84d-ba30-cabbf750c874@ti.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Roger,

On 2/26/20 2:42 AM, Roger Quadros wrote:
> Hi Suman,
> 
> On 25/02/2020 22:46, Suman Anna wrote:
>> From: Roger Quadros <rogerq@ti.com>
>>
>> The PRUSS module has a SYSCFG which is unique. The SYSCFG
>> has two additional unique fields called STANDBY_INIT and
>> SUB_MWAIT in addition to regular IDLE_MODE and STANDBY_MODE
>> fields. Add the bindings for this new sysc type.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>>   Documentation/devicetree/bindings/bus/ti-sysc.txt | 1 +
>>   include/dt-bindings/bus/ti-sysc.h                 | 4 ++++
>>   2 files changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.txt
>> b/Documentation/devicetree/bindings/bus/ti-sysc.txt
>> index 233eb8294204..c984143d08d2 100644
>> --- a/Documentation/devicetree/bindings/bus/ti-sysc.txt
>> +++ b/Documentation/devicetree/bindings/bus/ti-sysc.txt
>> @@ -38,6 +38,7 @@ Required standard properties:
>>           "ti,sysc-dra7-mcasp"
>>           "ti,sysc-usb-host-fs"
>>           "ti,sysc-dra7-mcan"
>> +        "ti,sysc-pruss"
>>     - reg        shall have register areas implemented for the
>> interconnect
>>           target module in question such as revision, sysc and syss
>> diff --git a/include/dt-bindings/bus/ti-sysc.h
>> b/include/dt-bindings/bus/ti-sysc.h
> 
> Did you intentionally leave this here? It should be part of 2nd patch?

No, not really, include/bindings are also considered part of bindings.
This patch alone should be enough for you to add the DT nodes.

regards
Suman

> 
>> index babd08a1d226..76b07826ed05 100644
>> --- a/include/dt-bindings/bus/ti-sysc.h
>> +++ b/include/dt-bindings/bus/ti-sysc.h
>> @@ -18,6 +18,10 @@
>>     #define SYSC_DRA7_MCAN_ENAWAKEUP    (1 << 4)
>>   +/* PRUSS sysc found on AM33xx/AM43xx/AM57xx */
>> +#define SYSC_PRUSS_SUB_MWAIT        (1 << 5)
>> +#define SYSC_PRUSS_STANDBY_INIT        (1 << 4)
>> +
>>   /* SYSCONFIG STANDBYMODE/MIDLEMODE/SIDLEMODE supported by hardware */
>>   #define SYSC_IDLE_FORCE            0
>>   #define SYSC_IDLE_NO            1
>>
>