Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp59737ybf; Wed, 26 Feb 2020 08:48:34 -0800 (PST) X-Google-Smtp-Source: APXvYqwZNVOgiMly7WztDqURGWb+w5ltJKi17OWh6CKtTc8DqX+Wb2jSnRGdNduSauiczESH0tOg X-Received: by 2002:aca:44c1:: with SMTP id r184mr3680546oia.151.1582735714103; Wed, 26 Feb 2020 08:48:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582735714; cv=none; d=google.com; s=arc-20160816; b=WinwqkzsbMWNTuEgQM4HC6fBHKhXYeb47d7FISSkZVhKitYKk4bK7i8elBtFVkCRWA cA31gCvoWAa9TZccHdSU0E1dMSeq1XiyJcLLEU5apQFzz6rkUuvBdqZvy+7ZKXB99FHu IHRjycPVw9MBVP9xouR++SoT+Pqz7ubFPUy+hmFaBpLKsGepS4G97UQKnZivgt8ng1Bs pjy4m38TBNlBKT9DVXcu/HL9NA5dVBUklB2RuP2NCSghLwVKNjAYWRaAAnddOpucRc9e sXdXY/mHxYHyZxYMB74gfc55mcDvWl53UsZ28W/2/S//eftTSCOZ+VEKS2uGf7Howc+v 1HmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=huY+P9hCQip220Mv8ZYOmfoV11gqLVl0vDpN9hWczCE=; b=jKVoE5svkQbe+dQA5NViZLXdPZP+yigMD/jQyCGoUqxj6n1ENuGR4XezXwOp//6rK2 pDnpuQVOKKSNA5BiwUd6i400p3LZQKeDkWrvn9S3jxbSLPQPMUNjFwiTplSmhU3YriHJ YO8Pkuduq74hKxmq2grWE0g8Cid6r4qR1Dvav9ArbKNaTti/3Ymbp3g8pSx+LN+aB7A0 fW5eCN26ykO1Fv8iFrA3CiTDbAVfDU2MaKAHr3ojCVjVTGwOTj/1Z8TKo16aWM2p/AzB aekPetmaFTNPt1sj9vWVoZq91UM+W7FXGsN1gVAQQWqoSbnBoqjQBp4nKpH8ufgLGOcX DKkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si44018otd.280.2020.02.26.08.48.22; Wed, 26 Feb 2020 08:48:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727503AbgBZQmV (ORCPT + 99 others); Wed, 26 Feb 2020 11:42:21 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:44946 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgBZQmV (ORCPT ); Wed, 26 Feb 2020 11:42:21 -0500 Received: by mail-oi1-f194.google.com with SMTP id d62so93467oia.11; Wed, 26 Feb 2020 08:42:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=huY+P9hCQip220Mv8ZYOmfoV11gqLVl0vDpN9hWczCE=; b=R8wlhVVOE2B8Q5PLP5ulAcM4aZjHTJi1QMTc25536SjZRDgqx5afa2bQ7TNcEZcwjC tiqCbaqjVU9Yq9eNHgGP25PZuUJ67Zp1pfaJ8TA2CJRgnF05IYM8vI8I1aymYOK9jg+D //qyLg8Uma6v7SfCrrHpOi/3ABoDq7NUqJHR/mIdmRhgMs7Ocj8PReIVjc4qEZTAz6sf OrKPNdcnGcCDIJXyAZUfuNN3VrIKV0egPZEUctxFDk8Sg7aZpKVS0rmyv3KVd7HseyMK nq1JiKOfo/UOA5WgwW+hjetZsqA4qT2+qhKE5je6T8RSYq0ksHrcyiSLUJa6hm1YtAP0 3jOQ== X-Gm-Message-State: APjAAAVgMLyAGy4NMtsQDFTVlRYBT8wQRSJWU44yj++LnQmQ16kIm/+T uscLk7Zve219EmIg0Z+aiA== X-Received: by 2002:aca:c646:: with SMTP id w67mr3694200oif.171.1582735338594; Wed, 26 Feb 2020 08:42:18 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l1sm970643oic.22.2020.02.26.08.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 08:42:17 -0800 (PST) Received: (nullmailer pid 10602 invoked by uid 1000); Wed, 26 Feb 2020 16:42:17 -0000 Date: Wed, 26 Feb 2020 10:42:17 -0600 From: Rob Herring To: frowand.list@gmail.com Cc: Geert Uytterhoeven , pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Tull Subject: Re: [PATCH v2 2/2] of: unittest: annotate warnings triggered by unittest Message-ID: <20200226164217.GA10550@bogus> References: <1582224021-12827-1-git-send-email-frowand.list@gmail.com> <1582224021-12827-3-git-send-email-frowand.list@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582224021-12827-3-git-send-email-frowand.list@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Feb 2020 12:40:21 -0600, frowand.list@gmail.com wrote: > From: Frank Rowand > > Some tests in the devicetree unittests result in printk messages > from the code being tested. It can be difficult to determine > whether the messages are the result of unittest or are potentially > reporting bugs that should be fixed. The most recent example of > a person asking whether to be concerned about these messages is [1]. > > Add annotations for all messages triggered by unittests, except > KERN_DEBUG messages. (KERN_DEBUG is a special case due to the > possible interaction of CONFIG_DYNAMIC_DEBUG.) > > The format of the annotations is expected to change when unittests > are converted to use the kunit infrastructure when the broader > testing community has an opportunity to discuss the implementation > of annotations of test triggered messages. > > [1] https://lore.kernel.org/r/6021ac63-b5e0-ed3d-f964-7c6ef579cd68@huawei.com > > Signed-off-by: Frank Rowand > --- > changes since v1: > - none > > drivers/of/unittest.c | 375 ++++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 345 insertions(+), 30 deletions(-) > Applied, thanks. Rob