Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp65196ybf; Wed, 26 Feb 2020 08:55:03 -0800 (PST) X-Google-Smtp-Source: APXvYqwhK2wPX1EFkFwMFTZsTKRL+dvVCBmfLkByh6JLl3HTMHGvgPdOjRkRbI1eyGcc99apF6Yn X-Received: by 2002:a54:4f14:: with SMTP id e20mr3796394oiy.84.1582736103101; Wed, 26 Feb 2020 08:55:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582736103; cv=none; d=google.com; s=arc-20160816; b=pZboZYnDg9iG+CSE8GSnrPb8eZy+ykPI/rASahrfq/zHVGGWGbFKDiynL1kc6tAgXQ d6C4a/NMkVmCoFDgCS75AJJngn41WdkRQwNwu+24SAaDZtgKfuRcmhzjEO72SvRRzfj8 KeXXxisySev6JQk1XTcKpewE/LPmdZfQr+W472u6ygOs/SIJdXrLtFAgJgQRa1y8FgqI QsPPXcPCwIa0TAb8dPzEp+FLn6iPIXFBGVX/5YFpF7jUAaDm6yqnLOjh/Ib0TzuCwd+k yz2i+LaHcAUHxB2bpiKwX3TNgaUfQpw99tCc6lomCih2Vr9LBm0wGuGWzEidWq3vrJTk bsdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=guM4OpdFkzMxFs+PgFy8AJyhxiplRkgPA//Rl2LhLTY=; b=QU4nPoVvDG0VKWamBuazh8VrFpqWq9C0m6nXhWa6mRzENVEFDAVbpp8BYEkGVX5Zup ZPP2oA09W+EAJCL9wXhV8ByE9uc8gCOKOyq/6l6UyxOhYSPM+glPX0QIq2NGVhO6cKEq AtTPS71IrDKGpW4fLvwQF2Ln/f+9TjYOyBuXlE5hviBtfJc2lVUa1BG0lDU58AYbHYNf y7FGqQS/XqKDE1w+Qflr0H2SI1mA2TZK0sh0Y+Ad4BARriugi5iz5ctNWT/n958BNnHs 5FoqsXaN1sa/5p0Yn2s6wO1Zdb+eLr6b9zh7t87sjofUZ0ktPhc6PRGIlxEGKDxqZYvG 36WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=ksFQBlVY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si43670otk.290.2020.02.26.08.54.51; Wed, 26 Feb 2020 08:55:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=ksFQBlVY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727185AbgBZQyg (ORCPT + 99 others); Wed, 26 Feb 2020 11:54:36 -0500 Received: from merlin.infradead.org ([205.233.59.134]:60070 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbgBZQyf (ORCPT ); Wed, 26 Feb 2020 11:54:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=guM4OpdFkzMxFs+PgFy8AJyhxiplRkgPA//Rl2LhLTY=; b=ksFQBlVYLER9KPti8/cCDfbJY0 HpPbiGwPavhqc1Lszn93ZzT5WznkCmFdxT/abi5oz9nf+5XAtNjy/UJRppcPJsGodZdutQq+SUeB5 AB8gW8gvJl9nKxXtGzCQgaDBriCIROrQDVMd8jFeVZ6+6Xxk7BX7dsRlyQnRnz4RumXcgkUBipbXF PmG+YbU/zT9DkPxPUNNNMs8wvCcNEcQv3XcSm5tvG4SuWgV7jZsjL3FvwwEBJA16ZMzDQsWZYRg6u Ky2mzPqYf//wE0fbAKAc0DoU5TWqg0DJwejK1hqy/yKFAozI5LWmAhuUyepj9Ag3YXSqdF2d3zBcL AQQqCQHg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6zwn-0001sE-Ui; Wed, 26 Feb 2020 16:54:10 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 23647300130; Wed, 26 Feb 2020 17:52:11 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5DC962B756CD9; Wed, 26 Feb 2020 17:54:07 +0100 (CET) Date: Wed, 26 Feb 2020 17:54:07 +0100 From: Peter Zijlstra To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, Patrick Geary , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Mauro Carvalho Chehab , Josh Poimboeuf , Andrew Morton , Pawan Gupta , Juergen Gross , "Rafael J. Wysocki" , Viresh Kumar , Daniel Drake , Michael Zhivich , linux-doc@vger.kernel.org Subject: Re: [PATCH] x86/tsc: Add kernel options to disable CPUID and MSR calibrations Message-ID: <20200226165407.GB18400@hirez.programming.kicks-ass.net> References: <20200226164308.14468-1-prarit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226164308.14468-1-prarit@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 11:43:08AM -0500, Prarit Bhargava wrote: > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index dbc22d684627..0316aadfff08 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -4942,7 +4942,7 @@ > See Documentation/admin-guide/mm/transhuge.rst > for more details. > > - tsc= Disable clocksource stability checks for TSC. > + tsc=option[,option...] Various TSC options. > Format: > [x86] reliable: mark tsc clocksource as reliable, this > disables clocksource verification at runtime, as well > @@ -4960,6 +4960,12 @@ > in situations with strict latency requirements (where > interruptions from clocksource watchdog are not > acceptable). > + [x86] no_cpuid_calibration: Disable the CPUID TSC > + calibration. Used in situations where the CPUID > + TSC khz does not match the actual CPU TSC khz > + [x86] no_msr_calibration: Disable the MSR TSC > + calibration. Used in situations where the MSR > + TSC khz does not match the actual CPU TSC khz. Do we want to mention that these situations are mostly broken firmware? Also do mention that if you disable these you might not boot due to not having a PIT/HPET at all? As it stands, I find this text a little too encouraging. > tsx= [X86] Control Transactional Synchronization > Extensions (TSX) feature in Intel processors that