Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp99097ybf; Wed, 26 Feb 2020 09:30:22 -0800 (PST) X-Google-Smtp-Source: APXvYqzGh6f0JOiqgl6S8+WjqUlYodH6r+y/NzQgMItPF08NkQy0hIYAwJuAj79hnX4JtB+MwIt+ X-Received: by 2002:a9d:7309:: with SMTP id e9mr1064612otk.260.1582738222456; Wed, 26 Feb 2020 09:30:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582738222; cv=none; d=google.com; s=arc-20160816; b=EL0LDkKf6/G0PG3mVM1jNxl+9qu2FUypZxflaKCaTgqgEgpEcsILXtfG0om9Ol/GdW CIBNc0G6KDTRTaEkgjYnnalBh1PyIB9TY9TqmocDjC/CTX3Pw95IfTTHHYlAM1EV0yqH P01GiiofDvQ/Lg1zds4Zy5Vn34vnuxkrXSGz71sPHNwwox4Rm2OWNOcTi0jGYGPZEeUT XNEHjs/SWpg6vyxiBa9MdpBDazTRcdYZQtr1Ug0I6dcVJyEsl8MwpykJDY+hbrZuk3gW tQHxngRoV66CX+mTXsGAa0AYuskTxRUXfoxf81a9NZg3zmi4eM0y4zypezFCEmfzLdHN VS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ymj0Ly4J86J6p81n4Q1BWG2BwGwoxs0lUBZwS7HU/mA=; b=rtMpH2yDn1Spwnd1rPsKd08eVr8i7UDqS2BfkDsf3Fobxluxz/DXVmRoEyV1O5y8KY Li5ddwJNDpAaiWd45nsopnoadEkV5IAfuHXnH9qNjbiQIDCzwMchVaodI8cQfdV8+EKt c5fE7n+8rPae9tuZO0Ka/Hwt+qs9X4ZKh79Sm1pc9l6N5Ulh7xUEW4c6rRjv+DZYGfsi kiO6q9yKZTY0FGE9mX+elKrs9ZFE4LRNS8Rf/L5VwmnjLPto9DxvXbEXlpeRvjCKA1DD OhvGIB7pRBDXC4rJdoU8Nj1JBLDcUGh9EEJyUNgK+dIkjur3cpvXSKYhMXknYxc6dgi0 Y1Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10si122080otd.219.2020.02.26.09.30.09; Wed, 26 Feb 2020 09:30:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbgBZR35 (ORCPT + 99 others); Wed, 26 Feb 2020 12:29:57 -0500 Received: from muru.com ([72.249.23.125]:57796 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726661AbgBZR35 (ORCPT ); Wed, 26 Feb 2020 12:29:57 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 299058022; Wed, 26 Feb 2020 17:30:42 +0000 (UTC) Date: Wed, 26 Feb 2020 09:29:54 -0800 From: Tony Lindgren To: Lokesh Vutla Cc: Daniel Lezcano , Thomas Gleixner , Linux OMAP Mailing List , linux-kernel@vger.kernel.org, narmstrong@baylibre.com, Sekhar Nori , Tero Kristo Subject: Re: [PATCH 2/2] clocksource: timer-ti-dm: Do not update counter on updating the period Message-ID: <20200226172954.GR37466@atomide.com> References: <20200224050753.17784-1-lokeshvutla@ti.com> <20200224050753.17784-3-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224050753.17784-3-lokeshvutla@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lokesh Vutla [200224 05:09]: > Write to trigger register(OMAP_TIMER_TRIGGER_REG) will load the value > in Load register(OMAP_TIMER_LOAD_REG) into Counter register > (OMAP_TIMER_COUNTER_REG). > > omap_dm_timer_set_load() writes into trigger register every time load > register is updated. When timer is configured in pwm mode, this causes > disruption in current pwm cycle, which is not expected especially when > pwm is used as PPS signal for synchronized PTP clocks. So do not write > into trigger register on updating the period. This patch without patch 1/2 applied still works for me: Tested-by: Tony Lindgren