Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp123718ybf; Wed, 26 Feb 2020 09:59:21 -0800 (PST) X-Google-Smtp-Source: APXvYqwENh3CKEVuxlJMS+1VVF/UhOBkrZaxMoVDFTIa0afoTC8ut31ORKdb5TTWmpIrqJuqwTSD X-Received: by 2002:aca:4f8e:: with SMTP id d136mr138516oib.61.1582739961349; Wed, 26 Feb 2020 09:59:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582739961; cv=none; d=google.com; s=arc-20160816; b=ed+ymT0flJVJk986eXU9Ygms6zcMNdTxsUZdJJf8pSovVVHPJ4Ce3O4TEC8VGaErn8 otxmyDsbjNNfznNMWzTyAbBu5MHt/v6bc3wxbXmmT7AyMrl8Y3OoqM20jxjn9clELQu7 73ukROnAhOfrrM0p1Z6RUfrxl+/TcjbwRcKOhdn+gYraJpEGV859VzPXWCiZTRWJqvFd R/8iez/R1TNrtIGizGjfgPTn0P90WqoAX6lFu/Gw4/K3JTN2zBXo6n6kJNdLHKLcFLjW KLZQgJexhoGwoUXCuM21gSLDZIo+3YAL2/4nYviFfN4ZWQ8UUjN8SoPEBjfN1UIFU75P dRHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YGj19SSEh4NZS+XJ9SnfJU1bKAnGI63LN3b4wv12M7w=; b=RQvpXhkIAA1OM5ri/cNn7z6ImoulBBxKWaUMAV/6RinWu6PfWZDV1fFJxta52/QSDk HNonbYwCSjyw3O1APnvCU5Rafk6cFi14UUaaJBAHoAT6PdAZvo06XdYnrZW5mkNliyPN Oi/fh7JvcMQW0SgW772PXbp8LAXWzOpntHY2BaLWI/RieNuhqYDMZvAocdG7+3qd/oS2 v7Tt5wGjRHFPcieztHGvvZbHX2JAD0RUPvPn33nLfge8PmUqhh30+pnZajnesBr+rGUd wTvwY/uJy6EsmCEHc3vrtQsAu5XQofOdoQPnzYumqacdaMRK76pQsEFlLLendPqoz8yA Ct5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=xX38UGP4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e126si8713oib.21.2020.02.26.09.59.09; Wed, 26 Feb 2020 09:59:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=xX38UGP4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727190AbgBZR5n (ORCPT + 99 others); Wed, 26 Feb 2020 12:57:43 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:51758 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726787AbgBZR5m (ORCPT ); Wed, 26 Feb 2020 12:57:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YGj19SSEh4NZS+XJ9SnfJU1bKAnGI63LN3b4wv12M7w=; b=xX38UGP4V16mODnfTy4JyCbqD CyLiniAUCMBJcrREDN4d0BZJm4uBv7I3+T1nSr8Hf49JYIgZ1VMbbluO72tjTEd0fRS/LN6SinN1b I04pqMPbS1uGvc33mNsQr/dqnG23VM4SZiAaYFLejRuGxw1z5BGV7az0Lk/UwS3yNx+AVdyoQV716 OlsuzrbP/iTGaIFNerZVT1hep9k0kvOooX6qcsh015Nm+cAdPSebby7EI011MCopu8Kyg6E1OrKlR uBY/t7gE8AAGlVpoye9SSV3k0SFDcZ4V9TF8WARnA8ht0b3Uk3fuEY9Pf5mnaxAdwMfdPGbr2rJD9 6IBqdSSZA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:53118) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j70w2-0000bu-13; Wed, 26 Feb 2020 17:57:26 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j70w0-0000AB-3X; Wed, 26 Feb 2020 17:57:24 +0000 Date: Wed, 26 Feb 2020 17:57:24 +0000 From: Russell King - ARM Linux admin To: Geert Uytterhoeven Cc: Marek Szyprowski , Geert Uytterhoeven , Nicolas Pitre , Arnd Bergmann , Eric Miao , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Chris Brandt , Linux ARM , Linux-Renesas , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: boot: Fix ATAGs with appended DTB Message-ID: <20200226175723.GF25745@shell.armlinux.org.uk> References: <20200225144749.19815-1-geert+renesas@glider.be> <20200226174905.GE25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 06:56:06PM +0100, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, Feb 26, 2020 at 6:49 PM Russell King - ARM Linux admin > wrote: > > On Wed, Feb 26, 2020 at 07:35:14AM +0100, Marek Szyprowski wrote: > > > On 25.02.2020 15:47, Geert Uytterhoeven wrote: > > > > At early boot, register r8 may contain an ATAGs or DTB pointer. > > > > When an appended DTB is found, its address is stored in r8, for > > > > extraction of the RAM base address later. > > > > > > > > However, if r8 contained an ATAGs pointer before, that pointer will be > > > > lost, and the provided ATAGs is no longer folded into the provided DTB. > > > > > > > > Fix this by leaving r8 untouched. > > > > > > > > Fixes: 137e522593918be2 ("ARM: 8960/1: boot: Obtain start of physical memory from DTB") > > > > Reported-by: Marek Szyprowski > > > > Signed-off-by: Geert Uytterhoeven > > > > The original commit hasn't been submitted, so it can be fixed before it > > hits mainline if you want. Let me know what you want to do. Thanks. > > Fixing the original is fine for me, of course. > Thanks! Please submit a replacement for 8960/1, thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up