Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 26 Feb 2020 11:01:30 -0800
From:   Kees Cook <keescook@chromium.org>
To:     Naresh Kamboju <naresh.kamboju@linaro.org>
Cc:     Cristian Marussi <cristian.marussi@arm.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        lkft-triage@lists.linaro.org,
        open list <linux-kernel@vger.kernel.org>, ankita@in.ibm.com,
        Will Deacon <will@kernel.org>, ardb@kernel.org,
        "Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>
Subject: Re: selftests: Linux Kernel Dump Test Module output
Message-ID: <202002261052.62C3132B0@keescook>
References: <CA+G9fYu3682XJ2Kw2ZvQdUT80epKc9DWWXgDT1-D_65ajSXNTw@mail.gmail.com>
 <fcb799d4-f316-60d6-9fd0-0bc1c174e63c@arm.com>
 <202002251131.3216B3B50C@keescook>
 <b485a8a9-5312-ca77-d091-3dbfac33ec5b@arm.com>
 <CA+G9fYuQJjf3v53HNj4TOAL2NcgDCYCrsUkfL6h93ntXO3WWwg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+G9fYuQJjf3v53HNj4TOAL2NcgDCYCrsUkfL6h93ntXO3WWwg@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 26, 2020 at 11:32:46PM +0530, Naresh Kamboju wrote:
> Yeah i see this case at my end also.
> 
> my two cents,
> I have two comments,
> 1) shell check

I'll fix these up; thanks for the suggestions!

> Test output with set -x for debugging shell scripts.
> [...]
> ++ dmesg -c
> +++ mktemp --tmpdir -t lkdtm-XXXXXX
> ++ LOG=/tmp/lkdtm-r5yZ7K
> ++ trap cleanup EXIT
> ++ /bin/sh -c 'cat <(echo BUG) >/sys/kernel/debug/provoke-crash/DIRECT'
> ++ true
> ++ dmesg -c
> ++ cat /tmp/lkdtm-r5yZ7K

This is the part that is failing and I don't know why.

clear the kernel event log:
	dmesg -c
trigger the kernel event:
	/bin/sh -c 'cat <(echo BUG) >/sys/kernel/debug/provoke-crash/DIRECT'
dump the newly added event logs into a file (set -x doesn't report
redirection to /tmp/lkdtm-r5yZ7K):
	dmesg -c

It seems /tmp/lkdtm-r5yZ7K is empty?

-- 
Kees Cook