Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp281947ybf; Wed, 26 Feb 2020 13:03:23 -0800 (PST) X-Google-Smtp-Source: APXvYqwn0nBbux8NpWFkhyX5qKGHztpX/IyJogTK+1qZv2+Ou1wQ3tp/NNzCgUOiBypn8VDI4vrA X-Received: by 2002:a9d:2264:: with SMTP id o91mr573076ota.328.1582751003056; Wed, 26 Feb 2020 13:03:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582751003; cv=none; d=google.com; s=arc-20160816; b=xLl5bPL0UoliEZiFa35F/bmP4foqLm609Er2ic8V+VhgnGlIn7/HRwH1ja5HdgVq6/ 3akLnCpHwGpada95Wnab5YXPcV2NJqP3E/laFQnG9PuYxvJge7kSW1IvKdFkKNvDxk5L K6aMd7+Lk5O2qtV4YZW6WcC7kvWIXnzd6A3vFmJcIWARxdearGQlOy6yfpKkqIEWw52a 0DO+fJp0MneZdu9owSjDRP16daU66syjIIzlGU9N1ctGo2ox79e2W/3YI+zUOaoZk2fN HaWuv720gOuC95GniVeIJHWy7YjLssDCW8vicHKddW7LNLD+fTjodmvv9aExJ896iZjR 3Mrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=lDYySzXkODgJLGVssOWV012ZKExgqeMxvuyl7sAlWNo=; b=P5SMvdAZttK3cWz0XTQOhjKiVR6xm+DB0rydJGracjBCL02I7dbbhdS6JXPOPrmb6/ aQ3AJy/A/rus7SZXqBisJ3RnVuuzLgJ5xNVOK2ccXpdUFGE69AUGyXDsVv/7wfeJJZO5 aLOgrClYJfVoDWu1FDhxDEQyRm7DoFUIm6gRv2CCNx8PelzkqfMu/7Hc1clfUiYstUf7 E4WSinBwkEzZCEgbEEhSP+whoOGOCM13o43NQVmW1TeYBld4H0ZQCv9yDYCpOSKY0EIC Q/oX1ovQ5gLTfce8lD2H+bCr9xTUt4AP1jruVj1n5VoWdIgePZbvOabsHsDllrgopBIv fZaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v207si214979oif.185.2020.02.26.13.03.10; Wed, 26 Feb 2020 13:03:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727590AbgBZVDD (ORCPT + 99 others); Wed, 26 Feb 2020 16:03:03 -0500 Received: from mga11.intel.com ([192.55.52.93]:27640 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727387AbgBZVDC (ORCPT ); Wed, 26 Feb 2020 16:03:02 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 13:03:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,489,1574150400"; d="scan'208";a="350479873" Received: from jekeller-mobl1.amr.corp.intel.com (HELO [134.134.177.84]) ([134.134.177.84]) by fmsmga001.fm.intel.com with ESMTP; 26 Feb 2020 13:03:01 -0800 Subject: Re: [PATCH v5 13/19] x86/cpufeatures: Add flag to track whether MSR IA32_FEAT_CTL is configured To: Sean Christopherson Cc: TonyWWang-oc@zhaoxin.com, acme@kernel.org, alexander.shishkin@linux.intel.com, bp@alien8.de, bp@suse.de, hpa@zytor.com, jacob.jun.pan@linux.intel.com, jarkko.sakkinen@linux.intel.com, jmattson@google.com, jolsa@redhat.com, joro@8bytes.org, kvm@vger.kernel.org, lenb@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-pm@vger.kernel.org, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, pbonzini@redhat.com, peterz@infradead.org, rkrcmar@redhat.com, shuah@kernel.org, tglx@linutronix.de, tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, x86@kernel.org References: <20191221044513.21680-14-sean.j.christopherson@intel.com> <20200225221234.GL9245@linux.intel.com> <1eaf6fbe-0adb-5074-3bc4-1e8327e0cdb3@intel.com> <20200225232900.GO9245@linux.intel.com> <5434303a-0742-3811-fd14-6445d296c0f0@intel.com> <20200226004258.GP9245@linux.intel.com> <20200226205745.GQ9940@linux.intel.com> From: Jacob Keller Organization: Intel Corporation Message-ID: <9a0a7373-f469-f2ae-c218-5821f805f0d8@intel.com> Date: Wed, 26 Feb 2020 13:03:01 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200226205745.GQ9940@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/26/2020 12:57 PM, Sean Christopherson wrote: > Bummer. Using clear_cpu_cap() instead of setup_clear_cpu_cap() was me > being fancy and trying to allow KVM to identify the case where VMX is > available and configured on some CPUs but not all. I'll work on a fix. > Hmm. Right. For that to work, you'd need to make this disabling happen significantly later, and/or fix setup_pku to somehow honor this properly. But it looks like rdmsr is global and not tied to a given CPU anyways? Thanks, Jake