Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp310419ybf; Wed, 26 Feb 2020 13:38:48 -0800 (PST) X-Google-Smtp-Source: APXvYqyR1b3a2u4frCCDkDIq7n10n3nQF57HOgN7lDKxD9UWKrF8/L4yrth7EUHbuGeFA7FQiN8g X-Received: by 2002:a9d:7653:: with SMTP id o19mr697887otl.118.1582753128074; Wed, 26 Feb 2020 13:38:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582753128; cv=none; d=google.com; s=arc-20160816; b=c385o8JM5tWWnF+Q0gs4csO/QdNsxpXszShgQtagE2SSsd81kVEFFr3jrRlO98UR+Y Qx7MJOoAuenmJyWJniBwaJFmlWT5wGiPB2GS0A/ZWlwx09Vlu6h+CAyLt6BbAdltp2TO huNJQCLzRldstG8qNR1Xd0ebUoNhSCsy87Jrh3HMEFGzcCJKhG9+vZCiRsItHrttaPdG OsY4l1au7ugL+n8jgcdGUO0rr+YioYIAY2SRqpZC3OvChl2ENp99hgMHttc+yOIfARnU DmlH0Cef0KVL0nlvUhLgWxubTUCAFNhrMlTj0PQofDw430q+vAujKLVX+7GaIHO6fNk/ czIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=MdGE6BkJQteoHqLFsX7TImGOPTqgSwWqtI5U+DIM000=; b=StgoDftuzI4uIG792pRG+gIzYmZxvWJgvYpkTXeTWPv+rVJpi/8Iv8Imlxz1PyXq6l XjoV33VzGDAeD3Xwpre8zcXPpMkZ7lG1SLhFW6GuZZ/325kcUkaP3ygT0m1RazugWzqe l2jZY+ELE5/em5tqsZ2pvPqeHFuY+eyJARKPLWf8QbDZsF71ReSayoacsJM93wdKTgZr N84rPv2gY0ebUrAXe5KPnJDViKSxYzLj1j8MHQf6W1nNwxAIXv+8c7hf0qAGV/cl4Uet oeR323pXG7GkDQajc9/1mMjqYL4slA3g58RNYpGdezrx5tWA4sHdAfhW6LNkq22AXXB/ YcJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hHn6LzED; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r82si239878oie.116.2020.02.26.13.38.36; Wed, 26 Feb 2020 13:38:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hHn6LzED; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727734AbgBZVg5 (ORCPT + 99 others); Wed, 26 Feb 2020 16:36:57 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34785 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727581AbgBZVg5 (ORCPT ); Wed, 26 Feb 2020 16:36:57 -0500 Received: by mail-pf1-f193.google.com with SMTP id i6so450078pfc.1 for ; Wed, 26 Feb 2020 13:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MdGE6BkJQteoHqLFsX7TImGOPTqgSwWqtI5U+DIM000=; b=hHn6LzEDcoli9XE2imSXc/0SNncPv+Co6E5fSIu6UY6oc8VoHpUFi6WhCwjXPHyPdi KadNY2PDkICluix8nWf1LkfQBvP/9yPl2vOcR51NoVMqa8OzqwDCPTZBk1fisiTHLnTI GSASYEl9NUi1JFSDvceRGcrmheoQkE+0mBl70= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MdGE6BkJQteoHqLFsX7TImGOPTqgSwWqtI5U+DIM000=; b=MVH2MahT9oD95lxR7YYk/oOojn1/QGWqj+efGUJeSNuWqBl8mbgoDQyvUf+zN5hidu tioj9t/fuL5t0lX6riNwXXeII6B1u0YWYX4F6qsPKMQhV2VeUNLWxmgZjMxIBFMQKkAS X+brHreHGPnNLOtnuGmgSLUjrL0SOKCKCKF5MEFBC6XAClwxnPiSrkFtsOj1n7n/llOg MbbV/AGXfniEd6uwJBy0vQ8iYPZuQ/+tNujfLV70S9+YGTWK8V+yqlbFR2QIrMlpNWr1 ccoUXR/8WGDNtwQcanRkKwJEL0vZJ1fk/9P786k2zsueD5974sqebP39N7kg7zl3FmfS WLfg== X-Gm-Message-State: APjAAAU2FiudbGF6polPb78ohJpL+shkt4XRju6LqI6WwgTEp938JhLT fGy7ONHXKnYPzPuZtzYoTJpqzw== X-Received: by 2002:a63:112:: with SMTP id 18mr809974pgb.116.1582753015247; Wed, 26 Feb 2020 13:36:55 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x7sm4242978pfp.93.2020.02.26.13.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 13:36:54 -0800 (PST) Date: Wed, 26 Feb 2020 13:36:53 -0800 From: Kees Cook To: Peter Zijlstra Cc: Andrew Morton , linux-kernel@vger.kernel.org, luto@amacapital.net, axboe@kernel.dk, torvalds@linux-foundation.org, jannh@google.com, will@kernel.org Subject: Re: [PATCH v2] mm: Fix use_mm() vs TLB invalidate Message-ID: <202002261336.7A72F3C@keescook> References: <20200226132133.GM14946@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226132133.GM14946@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 02:21:33PM +0100, Peter Zijlstra wrote: > v2 now with WARN_ON_ONCE > [...] > + WARN_ON(!(tsk->flags & PF_KTHREAD)); > + WARN_ON(tsk->mm != NULL); > [...] > + WARN_ON(!(tsk->flags & PF_KTHREAD)); Version mismatch? -- Kees Cook