Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp315370ybf; Wed, 26 Feb 2020 13:45:34 -0800 (PST) X-Google-Smtp-Source: APXvYqzpdiOUz1nCUgKWmXaYpncFOckRwcoWflIAmDY4flXDmx/xPCY/ynqfeOGhC39yuH6gSCBI X-Received: by 2002:a05:6830:150:: with SMTP id j16mr556033otp.301.1582753534326; Wed, 26 Feb 2020 13:45:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582753534; cv=none; d=google.com; s=arc-20160816; b=EWnnzum9scn+jUlTxScgKTqprGndaxckesrYVu+ePieJAl2yGgcV/QgiUmpyy3UlC9 EUIrfu6xDlZJFSxOw22iskmaQa9cZld1zqCuM9wCMG+EmFWWRfHIKJUAAQGrz9yKy6wj EnBFem/xUG2Bwqk0y7N6qr1zNfXsgTXmsL0CI74HlPVTGvwyEe5gxp4h2dFXCw+hPxPV kyzS7rgpWjH3x4pXEOdL7tOMEuQymY0isQ8XSEX4QHFMtE1XB/ONpbZmfWZ7flrE2e4g UOMniL5JdSWkIYpjXSNrTlszgqvBf75kjbWZCPGx2y8rQGW7XYBAln2rPlgXL+3t/5LP /xNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LEOG45oBzsk4VkXLaube4iedb24/mnkHl/uPB4eNLko=; b=Z0PS60d4dPBJmo0hMHb9YKP8xMLMpGeLUje5TpHXqRUHOxpUvBKshU+2m4YgIC2FqY 92taT+hAy2diFYD5AKjqoRVCC5GQcaVIOerWyDy0bvzPJQ34f97e4sl+4Z4Vqt60eo9O 9yS0IEPee+5dScwzuOwrbSx3fc171eqNRDicRJf+gUU3FdEpid3s3x+gX8IJrugU2lDy gk0l5hdcw8xD/rzW025uqzgs4mTXbq8VatVjFzzZYiJVOvyD9uViJHdJbKnaO5aNs4lF +EU9cOm1LLgavnbCq8swk4UaF5GABVUJH+spqkek+GDRrWThPHlXqq1HLcXm0kPw0UdF TeVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=S7Qwoill; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4si394536otk.66.2020.02.26.13.45.22; Wed, 26 Feb 2020 13:45:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=S7Qwoill; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727715AbgBZVpF (ORCPT + 99 others); Wed, 26 Feb 2020 16:45:05 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46048 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727689AbgBZVpD (ORCPT ); Wed, 26 Feb 2020 16:45:03 -0500 Received: by mail-pg1-f193.google.com with SMTP id r77so288897pgr.12 for ; Wed, 26 Feb 2020 13:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LEOG45oBzsk4VkXLaube4iedb24/mnkHl/uPB4eNLko=; b=S7QwoillPymvmUXhSvQ9XeY6dt1lsnuG9Gixb/80AnLRzal3BKqeXehLhN8GeIopi7 mHIWOeTf7r00dNMZbOY0wy/VeWQM2D1PWjaWm6VqnRhDTJ5RtWMC6V4WiBuONgAurgwS e6aKokF7WWW6DX6t/rtidzSu6L5+xiuBi/ihA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LEOG45oBzsk4VkXLaube4iedb24/mnkHl/uPB4eNLko=; b=aEZcMezrQMHneJAAvXfY8rrinS/z/YJPICtfWaEhmEV8/NXWa4uO8gtMTmK5ctFTqV aHb7C1aRqH3S2iaa/2MCoCSBy3tucwBHuXmqIu1f387VzdafvkyDyLaHrZRcyp/TNYEK alN2noY0mpyJ6P1RaRxqXwHRPtO6R1WyociuhL2GtEdnHnkUll9nK38Z49BYKWsmPCo6 TYTj/2GHINGGMmZBoaMRwiC5a4Q4Obxohz1qImTX68XKvDRg2ijzUCPpVcMvIZskxps5 jb/AojExNfvfT460+A+knJUTgJCU09rVMRvHxfO+WGoYLVkb1Tr63MZqO97+Bf7oFk2j +1JQ== X-Gm-Message-State: APjAAAUcGd7FU3rrQHTdH+8W6miqH4Mok4Bq6/XER7qk9WH5aGgVsnV7 N7PNvTr2w1mJR4zUYez04j1iow== X-Received: by 2002:a63:3004:: with SMTP id w4mr854365pgw.164.1582753500965; Wed, 26 Feb 2020 13:45:00 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z16sm4066910pff.125.2020.02.26.13.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 13:45:00 -0800 (PST) Date: Wed, 26 Feb 2020 13:44:59 -0800 From: Kees Cook To: Mark Brown Cc: Catalin Marinas , Will Deacon , Alexander Viro , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H . J . Lu " , Andrew Jones , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudakshina Das , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v7 00/11] arm64: Branch Target Identification support Message-ID: <202002261343.3B2ECE90@keescook> References: <20200226155714.43937-1-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226155714.43937-1-broonie@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 03:57:03PM +0000, Mark Brown wrote: > This patch series implements support for ARMv8.5-A Branch Target > Identification (BTI), which is a control flow integrity protection > feature introduced as part of the ARMv8.5-A extensions. > > Changes: > > v7: > - Rebase onto v5.6-rc3. > - Move comment about keeping NT_GNU_PROPERTY_TYPE_0 internal into first > patch. > - Add an explicit check for system_supports_bti() when parsing BTI ELF > property for improved robustness. Looks good. I sent a few more Reviewed-bys where I could. Who is expected to pick this up? Catalin? Will? I'm excited to have both the ELF parser and BTI landed. :) -Kees -- Kees Cook