Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp496291ybf; Wed, 26 Feb 2020 17:13:46 -0800 (PST) X-Google-Smtp-Source: APXvYqxs4Pbh3hM4LbgcDfa5EkVVCgRl4D1iQgM8BQpLDvHbxZFzKOpuh+0eo5aXPjhOnAmAE/Wv X-Received: by 2002:a9d:58cb:: with SMTP id s11mr1395646oth.55.1582766026302; Wed, 26 Feb 2020 17:13:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582766026; cv=none; d=google.com; s=arc-20160816; b=R5gRR/t/ifDKRShiQPdXjiz+0mHjTF9CdH9+/DzQn9ynNQ6q7MaxrJW0elw/D6asCH V5rci/uuJ1ybRAdXSbjVwL/jPigVMZBHIv+fgwKBjDkHKdcqwifdZTSDf7P933pqZaWq ypJO/J3UYEvq6g+i6zSMmY8tHS91s2kQqbhYuuKIOrdqVkUoArRt+5XrWyN6+1Tzusxc b+VW8sPB8Z0ACN86am3p1UxFSZz9JAPjN9xcCsBPqD1xtAmdPssVUFQLzUI0Mt8qwdEv YOGXyCtuFSS628fRzInppUvziLbgQm7OG36jTRyGai7f/1ESrrCVVNhKuFMEbXsHn4js AUgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=HRhbcWxgejDe6HeVo5uO1hHC/ovtGklo+TRkzrUDPIA=; b=ygC+vkNkc+21fCv+yL6AfhS96ZQvLG++2dUKx+VdvpwT5ikdiQ0ZUF9pozdNBM0kpj OLrm5+tc2Gpc3AgByAe0bxP8mWvo6sKZgPS5RRBzrCNUsB3oyx/l7NgIkzOcq50nF5gg Lcn3QzEq1UTBK9eHYoBPpQIfVPQvv2vi+eg6tHm/tMKjHoMj10bpbNr861Dixd4xa0sa Z6e+pG7oDEsePM3ljknmbn1F6y6UTZQcN0di0528YzYGf3LhlbZYIwtsIc9glE/X7Fjq Olu5DdoPAXAPf3DevigvWTai4Ogx/JggS3nMu0Wc8IhpGJnGnf1O4Xgl22mF/orC0Pya Yp1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si492818oih.89.2020.02.26.17.13.34; Wed, 26 Feb 2020 17:13:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728178AbgB0BN3 (ORCPT + 99 others); Wed, 26 Feb 2020 20:13:29 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:35774 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727964AbgB0BN2 (ORCPT ); Wed, 26 Feb 2020 20:13:28 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D066915AE21D4; Wed, 26 Feb 2020 17:13:27 -0800 (PST) Date: Wed, 26 Feb 2020 17:13:27 -0800 (PST) Message-Id: <20200226.171327.726312650027889484.davem@davemloft.net> To: nsaenzjulienne@suse.de Cc: opendmb@gmail.com, f.fainelli@gmail.com, wahrenst@gmx.net, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed From: David Miller In-Reply-To: <20200225131159.26602-1-nsaenzjulienne@suse.de> References: <20200225131159.26602-1-nsaenzjulienne@suse.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Feb 2020 17:13:28 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolas Saenz Julienne Date: Tue, 25 Feb 2020 14:11:59 +0100 > Outdated Raspberry Pi 4 firmware might configure the external PHY as > rgmii although the kernel currently sets it as rgmii-rxid. This makes > connections unreliable as ID_MODE_DIS is left enabled. To avoid this, > explicitly clear that bit whenever we don't need it. > > Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support") > Signed-off-by: Nicolas Saenz Julienne > --- > > Changes since v1: > - Fix tags ordering > - Add targeted tree Applied and queued up for v5.5 -stable.