Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp673974ybf; Wed, 26 Feb 2020 20:56:24 -0800 (PST) X-Google-Smtp-Source: APXvYqxwzrFLCheN9a1cRNEP5jkhbz6AO08U88PZmu8hzPCtE3bZWh6lQYSZqYAh+Iblslao17y/ X-Received: by 2002:a9d:7ccd:: with SMTP id r13mr1864942otn.56.1582779384161; Wed, 26 Feb 2020 20:56:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582779384; cv=none; d=google.com; s=arc-20160816; b=eNqFtavfnfJCVpq+Gq1J3FHJOXDPD8uxZT+8BeHb4ZCDWcWZaxyJWtyC5940/gxb1t FT9k5cvnmmuFT7GCy/10RFEJ+ODlTxdx5PId52akCXK/SUQt/YuTXTv7CB20J8z7qart 57EtKO/lOPlaL3P2BosjhGaceE9Q8QiJeJmO+QCh7E2DOFdKyu0SOAPAvAUfXX2eTPzA vLRTowcGCWcNBOWSI85J+Bktz13obCTcNSApgWodR5B6DaaP8e2uFNaF5afXXUSLzN3y Ae/UpkzZYbve4q0e7lAY0qPwq/R27eZtQQjoeDCLlmvfXDq/7aPztILu5ZZsC/BOJPU9 lWZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=mFdeu6Qwda/Z0MX52mxMSpeRvsDZctM4K4RBJNYTO84=; b=Ro2QzlkEJfmpYdGT8JkN+bKKlEbhAqm2pT1Ffa/lBcdb7ecoY4tc5PWg83JQ7xvBra CzrUQ9k8QAp5spRnPm0FNibV4ChkQhsTxPtFBoSr3vI/A8WTzZE7E3mxGBFiZiAOkjaO JWpYfAgP2KB1KQ/7AMN0wAD9xGJd9q/p51LurZHqPpuIz2AGX6Z/cZ/S8UMW0x836RbJ ros+z32fw96QB48u33ERC3+kIjsy0DyimLd90wXYZLENi0v5g4yykHxxq2i+WFC58Wb2 +P77xNG9ATYrDhtaz6yl1JzzeT2lp9HlwSDI130stT9pFfipmsev98t8RpjuJgWt2sZp HXpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q26si686205oij.38.2020.02.26.20.56.11; Wed, 26 Feb 2020 20:56:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728413AbgB0E4B (ORCPT + 99 others); Wed, 26 Feb 2020 23:56:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37160 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728273AbgB0E4B (ORCPT ); Wed, 26 Feb 2020 23:56:01 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5424915B47E20; Wed, 26 Feb 2020 20:56:00 -0800 (PST) Date: Wed, 26 Feb 2020 20:55:59 -0800 (PST) Message-Id: <20200226.205559.362242257227126401.davem@davemloft.net> To: aaro.koskinen@nokia.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: stmmac: fix notifier registration From: David Miller In-Reply-To: <20200226164901.21883-1-aaro.koskinen@nokia.com> References: <20200226164901.21883-1-aaro.koskinen@nokia.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Feb 2020 20:56:00 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: aaro.koskinen@nokia.com Date: Wed, 26 Feb 2020 18:49:01 +0200 > From: Aaro Koskinen > > We cannot register the same netdev notifier multiple times when probing > stmmac devices. Register the notifier only once in module init, and also > make debugfs creation/deletion safe against simultaneous notifier call. > > Fixes: 481a7d154cbb ("stmmac: debugfs entry name is not be changed when udev rename device name.") > Signed-off-by: Aaro Koskinen Applied and queued up for v5.5 -stable, thanks.