Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp792892ybf; Wed, 26 Feb 2020 23:28:11 -0800 (PST) X-Google-Smtp-Source: APXvYqz9lMipUzRS7cJYx6FnszdGki+UQL95AoFLgellEr8newigEKRYSCM9hm2SGDokdbdD4SSO X-Received: by 2002:aca:4309:: with SMTP id q9mr2313072oia.158.1582788491182; Wed, 26 Feb 2020 23:28:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582788491; cv=none; d=google.com; s=arc-20160816; b=f649s9Thq7J2Q2ceAlGbB59xvdFiGGGiis7lpNvqWeV088IbPPK4nLinDnhGbJHbci iT8OhvrPHvp26DCFcbkSmbPO2V6IPJQBlps+pbTIo3EhQP9uFh2qsKy2sNsktjgRiC6b Jp30CSEZdH6x22FJ8ycAebGneqC0XpCuy+sZBERapfHAxBcZA9X2gfacGp/rb0t8LQ8G jkJt5vbcgG6hHCj6x8xBEtMIfCQyD1nBWVU4JbLW23pPf6mcIxba5gtHytl8LnJQ+H8P 76tMBjkKCEx2Apysi2P8s4Md2AoLFMk0LxUyH4Y9NlvuhHE/8uFPt3IxtVhTJD3SWv8T GguA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=TJGSEt2sv0sEZXx4K93eb6xjPcWeRII6mj6QVI2PoVg=; b=oHXOcSYIqX0s45x9pLUhWvjhuuiBTRT7y1Q+rmExCtNIWesZO6m/JHAv0OZLzlR22x 19JSYUkN1I4d/6XdClK15eIxtPHMmCylG1hd0VoZSa6tZSH9pEtu3EPTvkF5dAv8HJsb Jgzdg953pwE+kCtOj+00o8Z4nmHNTOD65flbMs83wH0ce6jqmZg9zw2oc3QxBow5Ae1r 0vR/MNYoXhqQPTk8FgZuLg79YHlQrj1y9THQrFMcRQIIGooNRL8dz5kpA0I1EhxZ+rJV ZmbNTo2J18wh4madCwgE4hZb1nPh/S88ZlfT2Wuq6t9rbXQsI5TfEdswImuj+yJEjAN3 rTHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1si1094514otg.113.2020.02.26.23.27.59; Wed, 26 Feb 2020 23:28:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbgB0H1A (ORCPT + 99 others); Thu, 27 Feb 2020 02:27:00 -0500 Received: from alexa-out-blr-01.qualcomm.com ([103.229.18.197]:58490 "EHLO alexa-out-blr-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726999AbgB0H1A (ORCPT ); Thu, 27 Feb 2020 02:27:00 -0500 Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 27 Feb 2020 12:55:59 +0530 Received: from mkrishn-linux.qualcomm.com ([10.204.66.35]) by ironmsg02-blr.qualcomm.com with ESMTP; 27 Feb 2020 12:55:41 +0530 Received: by mkrishn-linux.qualcomm.com (Postfix, from userid 438394) id 94573443D; Thu, 27 Feb 2020 12:55:40 +0530 (IST) From: Krishna Manikandan To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Krishna Manikandan , linux-kernel@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, hoegsberg@chromium.org, kalyan_t@codeaurora.org, nganji@codeaurora.org Subject: [v1 2/2] msm: disp: dpu1: fix reservations cleanup during modeset Date: Thu, 27 Feb 2020 12:55:32 +0530 Message-Id: <1582788332-7282-2-git-send-email-mkrishn@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1582788332-7282-1-git-send-email-mkrishn@codeaurora.org> References: <1582788332-7282-1-git-send-email-mkrishn@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Missing return statement will cause the reservations to get released prematurely, thus messing up the allocation for any next successive datapath reservation. Signed-off-by: Krishna Manikandan --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 136e4d0..0052212 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1084,6 +1084,8 @@ static void dpu_encoder_virt_mode_set(struct drm_encoder *drm_enc, dpu_enc->mode_set_complete = true; + return; + error: dpu_rm_release(&dpu_kms->rm, drm_enc); } -- 1.9.1