Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp812223ybf; Wed, 26 Feb 2020 23:53:11 -0800 (PST) X-Google-Smtp-Source: APXvYqwZCjsNEcgm00XO8OYn9nNZbFWJLedww4ALGhjDb4c8Zik4RptKwS4/brrAmY34/qhWZ/ue X-Received: by 2002:a9d:638a:: with SMTP id w10mr2353712otk.130.1582789990903; Wed, 26 Feb 2020 23:53:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582789990; cv=none; d=google.com; s=arc-20160816; b=lLsdzo04yqwaJW6W+w2AYeUgy/ZUDIXqtod/DI6iNOWCbfGF1prsTVekDRCkjU3XDM YSqE2wER5Dgagf8+FzmAUg5ztS9GNK4IXXdQnO1fpncmwmRFl54UODET7RXmObICRLhc hgOwyXBRTKy8Soq/Bse77eKp2jpL3YgsdtS6ah2r7CXq6tND0p/eLIgxcvtxJkZaY3Io tpCKszRrZcoUcc5ErN3QXwd+yq38rDYDZKWzNG8+Vau7yQ1W1NP0hn9qYiOwXj7/KMtd wiR/PPoAUk209hIO4qzd/UqyjCE99BVNHGs79/Ryms54q3qiQRGiq8qUkFtRT17VGXmn MaFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=W/BXaoa9fPypLDB0ld+zQr5fh/QNY7OIp05Sowu6WEc=; b=WJHi/oViOXEt707yor/pQWDCa2bOrK1HSGcXg75OaOfykkY3hmAt3eFluH1J3pj7GH tFgaer9pzfKddWdyDaGV/gI/bKwYimcmXDMc4E54clnn9Tbwy+Z0FcOEmDDIpmTaCklU 7UkQwtsnxGzJknXh0+KE6D8nwROA4Wyblr1znJqvmD7e926GkTP/kRxLrM4vFBsy0ZNg PYO5A0WTlHDrPNYFaPneGHIrYL40n8TtILd3s5mQw/P8wG1th3HBnaCzZSNLZejBRd4h 7MjCl75BgRmaSKXe0eMu94MSPekHKg6pgJMOsLd7o8pn4nbEk/toBYevVjk2dUVbq4pY Pn3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si1029513otc.160.2020.02.26.23.52.57; Wed, 26 Feb 2020 23:53:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728613AbgB0HvF (ORCPT + 99 others); Thu, 27 Feb 2020 02:51:05 -0500 Received: from mga05.intel.com ([192.55.52.43]:46429 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728426AbgB0HvE (ORCPT ); Thu, 27 Feb 2020 02:51:04 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 23:51:04 -0800 X-IronPort-AV: E=Sophos;i="5.70,491,1574150400"; d="scan'208";a="285249023" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 23:51:00 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id C5F30209DF; Thu, 27 Feb 2020 09:50:58 +0200 (EET) Date: Thu, 27 Feb 2020 09:50:58 +0200 From: Sakari Ailus To: Steve Longerbeam Cc: linux-media@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Thomas Gleixner , Hans Verkuil , open list , "open list:STAGING SUBSYSTEM" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [RESEND PATCH v3 02/17] media: v4l2-fwnode: Pass notifier to v4l2_async_register_fwnode_subdev() Message-ID: <20200227075058.GD5379@paasikivi.fi.intel.com> References: <20200215194136.10131-1-slongerbeam@gmail.com> <20200215194136.10131-3-slongerbeam@gmail.com> <20200225150721.GO5379@paasikivi.fi.intel.com> <33258045-b708-1390-06e0-fde224296dfb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33258045-b708-1390-06e0-fde224296dfb@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 03:50:04PM -0800, Steve Longerbeam wrote: > Hi Sakari, > > Thanks for the feedback. > > > On 2/25/20 7:07 AM, Sakari Ailus wrote: > > Hi Steve, > > > > On Sat, Feb 15, 2020 at 11:41:21AM -0800, Steve Longerbeam wrote: > > > Instead of allocating a notifier in v4l2_async_register_fwnode_subdev(), > > > have the caller provide one. This allows the caller to implement > > > notifier ops (bind, unbind). > > > > > > The caller is now responsible for first initializing its notifier with a > > > call to v4l2_async_notifier_init(). > > > > > > Signed-off-by: Steve Longerbeam > > Instead of improving v4l2_async_register_fwnode_subdev(), could you convert > > the users (IMX driver in this case) to call the preferred APIs instead? > > I presume you mean using v4l2_async_notifier_add_fwnode_remote_subdev(). Ok, > I'll convert to use that API. Thanks, Steve! -- Sakari Ailus