Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp846243ybf; Thu, 27 Feb 2020 00:32:45 -0800 (PST) X-Google-Smtp-Source: APXvYqwKabJJZS1QmYOTUBWkGPhLOFhsI0FY5VAwXuGdRpCrzstNgyNedy1q4zPeUkkolmpn5M0b X-Received: by 2002:a9d:6ac2:: with SMTP id m2mr2346059otq.191.1582792365161; Thu, 27 Feb 2020 00:32:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582792365; cv=none; d=google.com; s=arc-20160816; b=qj4Wnc+ZQedV1gMmdFF+gv/4Wc3kbMG8mcB91quy2dwjsYiCsKqaH2s/kJNEZmmyje 3x4rNhZ5Aro7K9DdJ1ERTvZ5ddSvAxHWUhpgeIdAn6PvftzmyaNozDpMLbec0FYI5PAA zwXFAg94Qwm2opwz0w7uydw1aiiZyBAIaxVf2KE31ADxWouUmgpvPSlKCkW0V/Uiwxgn stfukqeDZQOVI3xzhfUwZuH9BqlzhQUwmQdAgA2mS1zfZtGRYFvD8J1evddnZgdiAgrB w2gZ+ItEM3tDnDp05YXFNeRpTyohcGyJU9i880bPE4Pes/yJez5q2sDWdFTwjKdlQR8u jSKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject; bh=8Zgw06H3rfaH6Ryd4lXtl3ly+BwD8A3wIjjSoWfLCKM=; b=VPJbLsPxDuLJTvrCvFeij63rg6p2eZoU1M2qeXySdxHo1KR0X7hs9+PucOYJzPL//R bgUD6sOTixJj0KBW0ip7N/bSvTDaD+gRx8qArN29eL+4WUAEhZ5Ya+Zpx5xSFCltrCL8 9GlruQSLpAk6MQZNg30zBNl8VgpoGK5lvmEZWNqXx6d5+Q3qNHtwTXch2sKN8pVAD8tU JmaBsw3D654hXv58jTS8jlpL1bC4XZYIzlByDpWp0BiJ/ea70fRL13F8DpLiruPZuwDH gZfooFsmMJDcVoKWOAOuJmOkfwSSfEWUxs78nYrifnlX6DLjSIkZN/0DD21X/SFTKuNH L2VQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4si1073121otk.66.2020.02.27.00.32.32; Thu, 27 Feb 2020 00:32:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728606AbgB0Iay (ORCPT + 99 others); Thu, 27 Feb 2020 03:30:54 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:2876 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728454AbgB0Iay (ORCPT ); Thu, 27 Feb 2020 03:30:54 -0500 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01R8Pnf1140257 for ; Thu, 27 Feb 2020 03:30:53 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ydh922nwp-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Feb 2020 03:30:53 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Feb 2020 08:30:49 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 27 Feb 2020 08:30:41 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01R8UeRl48038088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Feb 2020 08:30:40 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AFC9242047; Thu, 27 Feb 2020 08:30:40 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 542E942042; Thu, 27 Feb 2020 08:30:40 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 27 Feb 2020 08:30:40 +0000 (GMT) Received: from [10.61.2.125] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 850F2A01C0; Thu, 27 Feb 2020 19:30:35 +1100 (AEDT) Subject: Re: [PATCH v3 15/27] powerpc/powernv/pmem: Add support for near storage commands To: "Alastair D'Silva" , alastair@d-silva.org Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-16-alastair@au1.ibm.com> From: Andrew Donnellan Date: Thu, 27 Feb 2020 19:30:38 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200221032720.33893-16-alastair@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20022708-0020-0000-0000-000003AE06E1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022708-0021-0000-0000-0000220624FF Message-Id: <49df8d51-f84b-3f2a-4df8-24569162bcf5@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-27_02:2020-02-26,2020-02-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 mlxlogscore=861 adultscore=0 bulkscore=0 mlxscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002270068 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/2/20 2:27 pm, Alastair D'Silva wrote:> +int ns_response_handled(const struct ocxlpmem *ocxlpmem) > +{ > + return ocxl_global_mmio_set64(ocxlpmem->ocxl_afu, GLOBAL_MMIO_CHIC, > + OCXL_LITTLE_ENDIAN, GLOBAL_MMIO_CHI_NSCRA); > +} Same comment as on the last patch - I think we're meant to be clearing this bit, not setting it to 1, -- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited