Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp950005ybf; Thu, 27 Feb 2020 02:32:51 -0800 (PST) X-Google-Smtp-Source: APXvYqybG2iqzmuLD0nIpRtH2ksSsHhViCJKBazysPaov/biXvhOt9bVKWRMhthhmZEe2q+sGnAr X-Received: by 2002:aca:190a:: with SMTP id l10mr2858391oii.56.1582799571221; Thu, 27 Feb 2020 02:32:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582799571; cv=none; d=google.com; s=arc-20160816; b=BxlaIHYeB9lNZ2Ky0NZkxAdT7NECu8DDabo0GpWT184kVIhtPPbqU0EC7qswhTPTfQ uNHBj5BqMM2VYnIXHiQ2PfACdN8o92YyzqP5lrLA5pGoskVmefuDWZgskhWeQ+efKuey SMEvbafbReBgNmvz9P+wGvErQ+cXk9XMBRXdRwOTUfo4o2CZ7lOli+jF3oKmH4dUYpme c8oyRiHMnv1W23UsV8vES57WARkfu9AbBLlmuaTaH4WTGMjCiZkKNxdXlHqvBvGUI9Kw alabAN3fuKZmGnVL0XIHPsJHG2b1GqljVC8YIMiD07UOcKrDYno8uVX2yNSmew32MJig fi6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=tHgj+CkAxYdnvNkjetHEF5ygXtiW0SGZV3uDVrR5lJ8=; b=Ct1hOWhKudLAJnF8ZFpAHtTGwcQvArEOCAyOlbNbPYiX3kkNWhRd6DbW0q2fZp/hZu SSmXyAI/80uNAz0LZsHnCDh6ZDrbHOGrzSHHe6IyGyMyh9hvfxbJ4XymrntUhMUC6ONn VoLLSAx+joMM1bQil3LvtEdeXeMQpiT17n8VOiYLgDYx2tLcarYnytefFk2FMj1lXN4I 1IiFFhfHIh6dYZcACmw/sUEL1wHhqMY+JIEe/gv1cHapFcGq4jA89SkaRJt6tFasUJPe WjeJg3CyTyToEKdoWloi4NtUIDBy+1YOZu0ubuXH4IkIqAn+H7q6EqUyhusioiMAWMHP UrJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si1323593otg.321.2020.02.27.02.32.38; Thu, 27 Feb 2020 02:32:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728852AbgB0Kbc (ORCPT + 99 others); Thu, 27 Feb 2020 05:31:32 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:33892 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728680AbgB0Kbb (ORCPT ); Thu, 27 Feb 2020 05:31:31 -0500 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j7GRn-0007Oi-T2; Thu, 27 Feb 2020 11:31:15 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 4CE0E10409C; Thu, 27 Feb 2020 11:31:15 +0100 (CET) From: Thomas Gleixner To: afzal mohammed , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, x86@kernel.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-ia64@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-omap@vger.kernel.org, linux-alpha@vger.kernel.org Cc: Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek Subject: Re: [PATCH 00/18] genirq: Remove setup_irq() In-Reply-To: References: Date: Thu, 27 Feb 2020 11:31:15 +0100 Message-ID: <87y2somido.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Afzal, afzal mohammed writes: > While trying to understand internals of irq handling, came across a > thread [1] in which tglx was referring to avoid usage of setup_irq(). > Existing callers of setup_irq() reached mostly via 'init_IRQ()' & > 'time_init()', while memory allocators are ready by 'mm_init()'. > > Hence instances of setup_irq() is replaced by request_irq() & > setup_irq() (along with remove_irq()) definition deleted in the last > patch. > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). thanks a lot for tackling this! Vs. merging this series, I suggest the following approach: - Resubmit the individual changes as single patches or small series to the relevant maintainers and subsystem mailing lists. They have no dependency on a core change and can be applied where they belong to. - After 5.6-rc6, verify which parts have made their way into linux-next and resubmit the ignored ones as a series to me along with the removal of the core parts. That way we can avoid conflicting changes between subsystems and the tip irq/core branch as much as possible. Thanks, tglx