Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp956961ybf; Thu, 27 Feb 2020 02:40:22 -0800 (PST) X-Google-Smtp-Source: APXvYqwn3LYm8ROwlVnOrBg0XrbADOLVunl/YPXGlo6WvhAScZcHLgRhZk6e9vYjG9vGzb0ZmYJZ X-Received: by 2002:a05:6808:9ba:: with SMTP id e26mr2746060oig.81.1582800022667; Thu, 27 Feb 2020 02:40:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582800022; cv=none; d=google.com; s=arc-20160816; b=IW9/swIXXpKkhO9+3Nlr5m/RbYEt+ETrxqFtQX/XrNYd9opwOddRg+iL4/xbiA7EzH c0aCwSo6O7y/gh5WJNEz1zKjuJiYO5IrVRqV3M9gRKuVqVaAVK28DWxa1vC1DOto+Y9Q 9oZclPxDNtwZU3faTtbqppjjIYq9SkB0XMOTeMs8XwacoFB4V50oUlGgiqXrrfqBgvED ZPTlNCje4y+yV6gOOBiBvwUIqAbO5YrUPEWadxUUq6XCwDtr5Piihj/QWdLpy3XQM1c7 JMF8r0saCRgVP6R4OByIebNg93xHd6TV1xTQaNo86z48yDJoHQYriSLymSNlusSeIgja FalA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature; bh=ohDNCMzAy83upjfyUzJEOTExlxxIJl91j/cton1k8WU=; b=vtKhmOsaT/6V71qu3W1v6mFH5CukGhrQAfKKtiUypxsPX7/uvFFmb4Nx6XQsFl/yIK 3Pb2xITDNOVADyoYPWcBbB48PWRUUsluxq++j/x1f3TdzRbSTW/ZcnkYC3e6FsWej2gV 20Y48wYNcWMUXUqxZVMLPOd06g9eFIn8HIIHQcm3v85pqL+Nx1WYaO0VvTvTD7FKiInF kLPyrPyiTQfnGsS3VwhYEXD1ceZFPhbazzLhL/kL6L26sCPjBsD8JLsXIXyUJmNYYg69 4r4AyFI4rWNnTkVJpnhvkDaAwstfNESzOnxDyHXKstY2PiemqDSFOK+P/18d59ez0KJ6 aFag== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=JkJhXN+J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h203si1121225oif.3.2020.02.27.02.40.09; Thu, 27 Feb 2020 02:40:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=JkJhXN+J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728759AbgB0Kj4 (ORCPT + 99 others); Thu, 27 Feb 2020 05:39:56 -0500 Received: from mail27.static.mailgun.info ([104.130.122.27]:22690 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728729AbgB0Kjz (ORCPT ); Thu, 27 Feb 2020 05:39:55 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1582799995; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=ohDNCMzAy83upjfyUzJEOTExlxxIJl91j/cton1k8WU=; b=JkJhXN+Jp0KASkmCMQQkl04gvZcoDRECHZjjyAoNJ62RFiv46uju/QdhGkmiA+bMGUyR89En Obq3nUaqeXTbdBx/SBz5I7Hv9WpeD6rzsutKoPX8Wkh9SfOfYrs9tLxHvRGrcJqgKsYl72hO FYl/WLMQv5O6eJB+A0zgTQ0hfLY= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e579c77.7f08f1739e68-smtp-out-n01; Thu, 27 Feb 2020 10:39:51 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 42428C4479F; Thu, 27 Feb 2020 10:39:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from codeaurora.org (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: stummala) by smtp.codeaurora.org (Postfix) with ESMTPSA id 10D07C433A2; Thu, 27 Feb 2020 10:39:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 10D07C433A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=stummala@codeaurora.org From: Sahitya Tummala To: Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net Cc: Sahitya Tummala , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] f2fs: Fix mount failure due to SPO after a successful online resize FS Date: Thu, 27 Feb 2020 16:09:37 +0530 Message-Id: <1582799978-22277-1-git-send-email-stummala@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Even though online resize is successfully done, a SPO immediately after resize, still causes below error in the next mount. [ 11.294650] F2FS-fs (sda8): Wrong user_block_count: 2233856 [ 11.300272] F2FS-fs (sda8): Failed to get valid F2FS checkpoint This is because after FS metadata is updated in update_fs_metadata() if the SBI_IS_DIRTY is not dirty, then CP will not be done to reflect the new user_block_count. Signed-off-by: Sahitya Tummala --- fs/f2fs/gc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index a92fa49..a14a75f 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1577,6 +1577,7 @@ int f2fs_resize_fs(struct f2fs_sb_info *sbi, __u64 block_count) update_fs_metadata(sbi, -secs); clear_sbi_flag(sbi, SBI_IS_RESIZEFS); + set_sbi_flag(sbi, SBI_IS_DIRTY); err = f2fs_sync_fs(sbi->sb, 1); if (err) { update_fs_metadata(sbi, secs); -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.